It's important that $params values not just get set without checking to see if something is there. In the case of hl.fl, the multilingual module simply wipes out whatever values existed before. This patch is not elegant but it allows the multilingual module to respect the incoming hl.fl values while adding its own.

This is a good example of why we need a better baseline API for these things.

CommentFileSizeAuthor
#2 915626_6.x-1.x.patch5.24 KBmkalkbrenner
#2 915626_6.x-2.x.patch5.25 KBmkalkbrenner
hlfl.patch1.34 KBrobertDouglass
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
CreditAttribution: mkalkbrenner commented
Status: Needs review » Needs work

There's no elegant way to solve this using the current API.
I guess this issue is related to #912304: Support apachesolr_multilingual.

But I think this patch does not solve the issue completely. To apply multilingual support to any apache solr contrib module we have to replace title, body, ts_*, and tm_* fields if they occur by their language specific equivalent. Ugly ...

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
CreditAttribution: mkalkbrenner commented
Version: 6.x-2.x-dev » 6.x-1.x-dev
Assigned: Unassigned » mkalkbrenner
Status: Needs work » Needs review
FileSize
915626_6.x-2.x.patch5.25 KB
915626_6.x-1.x.patch5.24 KB

I rewrote the patch to solve the issue for all possible language specific fields. Additionally I fixed some warnings and a compatibility issue which is caused by change in apachesolr where the serialization of hidden get parameters has been changed to json format. Without fixing that language filters don't work correctly.

@Robert: Are you able to test the 2.x patch?

wmostrey’s picture

wmostrey CreditAttribution: wmostrey commented

I tried the 6.x-2 patch and it doesn't solve the issue of #912304: Support apachesolr_multilingual.

wmostrey’s picture

wmostrey CreditAttribution: wmostrey commented
Status: Needs review » Needs work

Unless a clear test path can be given, this needs more work as per #3.

wmostrey’s picture

wmostrey CreditAttribution: wmostrey commented
Status: Needs work » Closed (fixed)

It appears that patch #2 has already been committed by Markus.
I'm closing this issue and will continue in #912304: Support apachesolr_multilingual

  • Commit ada28fe on 7.x-1.x, 6.x-3.x by mkalkbrenner: 
    [       ] mkalkbrenner: fixed some internal links in message boxes...