Problem/Motivation

I catched a PHP7.4 notice deprecation

Array and string offset access syntax with curly braces is deprecated in PHP 7.4. Use square brackets instead.

../apachesolr_multilingual/apachesolr_multilingual.install 57
../apachesolr_multilingual/apachesolr_multilingual.module 362

Steps to reproduce

Switch to php7.4, check logs

Proposed resolution

I would suggest to apply a patch

CommentFileSizeAuthor
#4 apachesolr_multilingual-offset-access-syntax-3192796-4.patch1.78 KBZertimon
#2 apachesolr-multilingual-offset-access-syntax-3192796-2.patch1.61 KBAndrei Haurukovich

Comments

Andrei Haurukovich created an issue. See original summary.

Andrei Haurukovich’s picture

Andrei Haurukovich commented
StatusFileSize
new apachesolr-multilingual-offset-access-syntax-3192796-2.patch1.61 KB
bzaher’s picture

bzaher commented
Status: Active » Needs review

The patch looks good. Tested with PHP7.4. Phpcs no longer reports a warning for these issues either.

Zertimon’s picture

Zertimon commented
StatusFileSize
new apachesolr_multilingual-offset-access-syntax-3192796-4.patch1.78 KB

Rerolled for 7.x-1.3