After running phpcs to the latest version getting the below php7 compatibility issues
FILE: sites/all/modules/contrib/apachesolr_multilingual/apachesolr_multilingual.index.inc
-------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
-------------------------------------------------------------------------------------------------------------------------------------------------
24 | WARNING | Function each() is deprecated since PHP 7.2; Use a foreach loop instead
90 | WARNING | Function each() is deprecated since PHP 7.2; Use a foreach loop instead
147 | WARNING | Function each() is deprecated since PHP 7.2; Use a foreach loop instead
296 | WARNING | Function each() is deprecated since PHP 7.2; Use a foreach loop instead
-------------------------------------------------------------------------------------------------------------------------------------------------
Comments
Comment #2
gaurav.goyal commentedComment #3
gaurav.goyal commentedComment #5
tarik.cipix commentedI have started another automated test for PHP 7.2 and tested the patch myself. Seems to be working, please include in next release.Comment #6
tarik.cipix commentedI have included another patch, the one in #2 isn't applying because the path is not relative. Please review.
Comment #7
tarik.cipix commentedI have included another patch, but I can't seem to get them to apply. Perhaps it needs to be a diff ?
Comment #8
rudolfbykerLet's try without the long file paths in the patch :) I also took the liberty of removing unused variables.
Comment #9
rudolfbykerSorry, the patch needs to be p1, not p0. Silly me. See https://www.drupal.org/node/707484
Comment #10
julien.reulos commentedLast patch applies correctly and fixes the issue, thanks.
Comment #11
ruyakhokhar commentedHi all, patch#9 is working fine. Screenshot attached.
Comment #12
ruyakhokhar commentedComment #13
vuilThe patch #9 works fine! It is ready to be committed. Thank you.