Missing reset() in term_reference_indexing_callback [#2959554]

In apachesolr_multilingual_term_reference_indexing_callback_implementation when language is undefined the PHP function "each()" is used to build key/values.

Since "reset()" is not called on the array, it is not garanteed that the internal pointer is at the "beginning" of the array.

This occurs on line 296 in the file apacesolr_multilingual.index.inc. Adding a "reset($node->{$field_name});" before line 296 should solve the issue.

Original code:

if (array_key_exists($node->language, $node->{$field_name}) && is_array($node->{$field_name}[$node->language])) {
      $items = $node->{$field_name}[$node->language];
    }
    else {
      list($lang, $items) = each($node->{$field_name});
      if (!is_array($items)) {
        $items = array();
      }
    }

With reset:

if (array_key_exists($node->language, $node->{$field_name}) && is_array($node->{$field_name}[$node->language])) {
      $items = $node->{$field_name}[$node->language];
    }
    else {
      reset($node->{$field_name});
      list($lang, $items) = each($node->{$field_name});
      if (!is_array($items)) {
        $items = array();
      }
    }

Comment	File	Size	Author
#3	apachesolr_multilingual_missing_reset-2959554-3.patch	520 bytes	candalt

Comments

Comment #1

9 April 2018 at 09:04

candalt created an issue. See original summary.

Comment #3

candalt commented 9 April 2018 at 09:14

Status	File	Size
new	apachesolr_multilingual_missing_reset-2959554-3.patch	520 bytes

Comment #4

wonder95 commented 27 June 2018 at 23:36

With the deprecation of the each() function in PHP 7.2.0, I came up with a much simpler and easier to read method of doing this:

    else {
      foreach($entity->{$field_name} as $lang => $field_values) {
        foreach($field_values as $key => $field_value) {
          $values[] = $field_value;
        }
      }
    }

Although it has to be modified for apachesolr_multilingual_term_reference_indexing_callback_implementation(), since for some reason it's different from all the other functions in this file and passes in $node and creates $items instead of $entity and $values:

    else {
      foreach($node->{$field_name} as $lang => $field_items) {
        foreach($field_items as $key => $field_item) {
          $items[] = $field_item;
        }
      }
    }