Hello,
I don't use apachesolr_search because I have my own rendering result.
So the dependency of apachesolr_search is not necessary for me.
Specially when i read this code (apachesolr_multilingual_apachesolr_query_alter):

else {
  // A custom query has been created by a third party module.
  // Assume default multilingual settings.
  // TODO This behavior should be somehow configurable.
}

What do you think?

CommentFileSizeAuthor
#5 remove_dependency_apachesolr_search-2400843-5.patch893 bytesmkalkbrenner
#4 remove_dependency_apachesolr_search-2400843-3.patch892 bytesNerOcrO
#2 remove_dependency_apachesolr_search.patch385 bytesNerOcrO
remove_dependency_apachesolr_search.patch478 bytesNerOcrO

Comments

Status: Needs review » Needs work

The last submitted patch, remove_dependency_apachesolr_search.patch, failed testing.

NerOcrO’s picture

NerOcrO commented
Status: Needs work » Needs review
StatusFileSize
new remove_dependency_apachesolr_search.patch385 bytes
mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented
Category: Bug report » Feature request
Status: Needs review » Needs work

Sounds reasonable. But the patch is incomplete. At least function apachesolr_multilingual_requirements() in apachesolr_multilingual.install needs to be modified.

NerOcrO’s picture

NerOcrO commented
Status: Needs work » Needs review
StatusFileSize
new remove_dependency_apachesolr_search-2400843-3.patch892 bytes

Ok thanks for your comment :)
I changed the .info with apachesolr finally, it makes sense.

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented
StatusFileSize
new remove_dependency_apachesolr_search-2400843-5.patch893 bytes

I think the check for apachesolr_search in hook_requirements needs to be inverted.

NerOcrO’s picture

NerOcrO commented

Hi mkalkbrenner,
Sounds good for me, thank's!