count(): Parameter must be an array or an object that implements Countable [#2957097]

I get the following warning about this module whenever I run a Drush command:

count(): Parameter must be an array or an object that implements Countable antispam.module:1545

My setup is as follows:
Drupal 7.58
PHP 7.2.2
Zend Engine v3.2.0, with Zend OPcache v7.2.2
Ubuntu 16.04.3
mysql 5.7.21

The code is within the antispam_user_load() function. It does not check if $moderator_types is an array or object before doing a count().

I will try to roll a patch for this later today.

Comment	File	Size	Author
#10	antispam-ensure-moderator_types-is-array-2957097-10.patch	643 bytes	junaidpv
#10	7.x-1.x: PHP 5.3 & MySQL 5.5, D7 7 pass
#7	2957097-define-array-antispam.patch	438 bytes	djdevin
#7	7.x-1.x: PHP 5.3 & MySQL 5.5, D7 4 pass, 3 fail
#5	2957097-define-array-antispam.patch	506 bytes	djdevin
#5	7.x-1.x: PHP 5.3 & MySQL 5.5, D7 Patch Failed to Apply
#3	antispam-ensure-moderator_types-is-array-2957097-12549587.patch	837 bytes	peterhebert
#3	7.x-1.x: PHP 5.3 & MySQL 5.5, D7 7 pass

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

29 March 2018 at 16:51

peterhebert created an issue. See original summary.

Comment #2

peterhebert CreditAttribution: peterhebert commented 29 March 2018 at 16:52

Issue summary:

View changes

Comment #4

peterhebert CreditAttribution: peterhebert at Rex Rana commented 26 April 2018 at 16:55

Status:

Needs work

» Needs review

Comment #5

djdevin

Philadelphia

CreditAttribution: djdevin at Cadmium commented 9 May 2018 at 19:52

Version:

7.x-1.6

» 7.x-1.x-dev

File	Size
2957097-define-array-antispam.patch	506 bytes
7.x-1.x: PHP 5.3 & MySQL 5.5, D7 Patch Failed to Apply

Same thing, one less line by fixing it at the source.

Comment #6

9 May 2018 at 20:00

Status:

Needs review

» Needs work

The last submitted patch, 5: 2957097-define-array-antispam.patch, failed testing. View results

Comment #7

djdevin

Philadelphia

CreditAttribution: djdevin at Cadmium commented 14 November 2018 at 20:43

Status:

Needs work

» Needs review

File	Size
2957097-define-array-antispam.patch	438 bytes
7.x-1.x: PHP 5.3 & MySQL 5.5, D7 4 pass, 3 fail

Comment #8

14 November 2018 at 20:54

Status:

Needs review

» Needs work

The last submitted patch, 7: 2957097-define-array-antispam.patch, failed testing. View results

Comment #9

bgm CreditAttribution: bgm commented 4 February 2019 at 13:10

Patch in #7 works for me. Thank you!

Comment #10

junaidpv

Kannur, Kerala

CreditAttribution: junaidpv at Detlus for Wickwood Marketing commented 15 March 2019 at 06:18

Status:

Needs work

» Needs review

File	Size
antispam-ensure-moderator_types-is-array-2957097-10.patch	643 bytes
7.x-1.x: PHP 5.3 & MySQL 5.5, D7 7 pass

#7 may not work well as it may cause to empty already populated array.

Here is improved one.

Comment #11

laurelstreng CreditAttribution: laurelstreng commented 9 May 2019 at 16:00

3 files were hidden/shown/deleted

File	Size
antispam-ensure-moderator_types-is-array-2957097-12549587.patch	837 bytes
7.x-1.x: PHP 5.3 & MySQL 5.5, D7 7 pass
2957097-define-array-antispam.patch	506 bytes
7.x-1.x: PHP 5.3 & MySQL 5.5, D7 Patch Failed to Apply
2957097-define-array-antispam.patch	438 bytes
7.x-1.x: PHP 5.3 & MySQL 5.5, D7 4 pass, 3 fail

Tested the patch provided by junaidpv in #10 and it is working for me – antispam-ensure-moderator_types-is-array-2957097-10.patch

My setup:
Drupal 7.67
PHP 7.2
Ubuntu 16.04
mysql 5.7.26

I was running into the following warning about this module whenever I ran a Drush command as well as in the database logs:
Drush warning: count(): Parameter must be an array or an object that implements Countable antispam.module:1545
DB Logs warning: Warning: count(): Parameter must be an array or an object that implements Countable in antispam_user_load() (line 1545 of /docroot/sites/all/modules/contrib/antispam/antispam.module).

1. Applied the patch by placing the patch in the same directory as the file being patched and run the patch command: patch < file.patch
2. Ran cron, cleared the site cache using drush, and checked the database logging /admin/reports/dblog
3. No longer seeing the warning when running drush commands
4. No longer seeing the warning in the database logs