In the current 7.x-dev branch, someone added extra spaces when composing the host name for spam/ham submit.

Check line 2395:

instead of:
$host = $api_key . ' . ' . $api_host;
it should be:
$host = $api_key . '.' . $api_host;

CommentFileSizeAuthor
#2 antispam-akismet_service-2379263-1.patch2.05 KBozin
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

BBC’s picture

I'm getting the following error in my logs, which may be related:

cheking a content failed: can not get a response back from the service provider Akismet

Tried suggested change above, but it doesn't seem to have helped.

[edit] Scratch that. The change didn't take the first time around. Looks like the change does in fact address the error.

ozin’s picture

Status: Active » Needs review
FileSize
2.05 KB

This patch fixed this bug in all functions which use $host variable with extra spaces and it works for me. Please review.

workplaysleep’s picture

Can confirm that this patch also works for me.

manyk’s picture

Status: Needs review » Reviewed & tested by the community
swelljoe’s picture

Also works for me (and doesn't work at all without the patch).

ozin’s picture

Priority: Major » Critical
marcoscano’s picture

It looks like the commit 40729e9 introduced this regression.

I can confirm that the current HEAD does NOT work, and the patch in #2 applies cleanly and solves the issue.

+1 for RTBC

Also, #2332515: Typo on line 2339 and #2294693: Whitespace in API Host URL appear to refer to the same problem.

  • cfinke committed b297b0f on 7.x-1.x
    Fix the invalid Akismet host names caused by superfluous spaces.
    
    Fixes...
cfinke’s picture

Status: Reviewed & tested by the community » Fixed

Fixed in b297b0f.

cfinke’s picture

Status: Fixed » Closed (fixed)
marcoscano’s picture

Thanks @cfinke for helping out with this!
Just a small remark, we normally tend to leave the issues in the "Fixed" status when they are resolved, and the bot will automatically mark them as "Closed (fixed)" two weeks later, if no new activity appeared on them.
Marking them directly as closed makes them disappear from dashboards of people following the issue.
Thanks again for your help!

cfinke’s picture

Thanks for the tip @marcoscano. I'm still getting the hang of the issue tracker, but I'll be sure to let the system auto-close the fixed ones from now on.

colan’s picture

I tried to set this to fixed (open), but cannot as I'm not a maintainer.

@cfinke: As well as #11, some other things to note:

  1. If someone else worked on the patch, it's important to give them credit. This can be fixed by reverting the commit, and then recommitting with the proper attribution (--author tag).
  2. Each commit message should be preceded by the issue ID, so that the repository can cross-reference with drupal.org.
cfinke’s picture

Status: Closed (fixed) » Fixed
cfinke’s picture

Thanks for the heads-up @colan. I'll redo any commits needing attribution ASAP.

  • cfinke committed 00a8c0f on 7.x-1.x
    Issue #2294693 by debain, manyk, ozin: Whitespace in API Host URL
    
    See...
colan’s picture

Still missing --author tag though?

cfinke’s picture

Discussing the need for an --author tag here: https://www.drupal.org/node/1389748#comment-12180388

cfinke credited debain.

cfinke’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.