Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
In the current 7.x-dev branch, someone added extra spaces when composing the host name for spam/ham submit.
Check line 2395:
instead of:
$host = $api_key . ' . ' . $api_host;
it should be:
$host = $api_key . '.' . $api_host;
Comment | File | Size | Author |
---|---|---|---|
#2 | antispam-akismet_service-2379263-1.patch | 2.05 KB | ozin |
Comments
Comment #1
BBCI'm getting the following error in my logs, which may be related:
cheking a content failed: can not get a response back from the service provider Akismet
Tried suggested change above, but it doesn't seem to have helped.
[edit] Scratch that. The change didn't take the first time around. Looks like the change does in fact address the error.
Comment #2
ozinThis patch fixed this bug in all functions which use $host variable with extra spaces and it works for me. Please review.
Comment #3
workplaysleep CreditAttribution: workplaysleep commentedCan confirm that this patch also works for me.
Comment #4
manyk CreditAttribution: manyk commentedComment #5
swelljoe CreditAttribution: swelljoe commentedAlso works for me (and doesn't work at all without the patch).
Comment #6
ozinComment #7
marcoscanoIt looks like the commit 40729e9 introduced this regression.
I can confirm that the current HEAD does NOT work, and the patch in #2 applies cleanly and solves the issue.
+1 for RTBC
Also, #2332515: Typo on line 2339 and #2294693: Whitespace in API Host URL appear to refer to the same problem.
Comment #9
cfinke CreditAttribution: cfinke commentedFixed in b297b0f.
Comment #10
cfinke CreditAttribution: cfinke commentedComment #11
marcoscanoThanks @cfinke for helping out with this!
Just a small remark, we normally tend to leave the issues in the "Fixed" status when they are resolved, and the bot will automatically mark them as "Closed (fixed)" two weeks later, if no new activity appeared on them.
Marking them directly as closed makes them disappear from dashboards of people following the issue.
Thanks again for your help!
Comment #12
cfinke CreditAttribution: cfinke commentedThanks for the tip @marcoscano. I'm still getting the hang of the issue tracker, but I'll be sure to let the system auto-close the fixed ones from now on.
Comment #13
colanI tried to set this to fixed (open), but cannot as I'm not a maintainer.
@cfinke: As well as #11, some other things to note:
--author
tag).Comment #14
cfinke CreditAttribution: cfinke commentedComment #15
cfinke CreditAttribution: cfinke commentedThanks for the heads-up @colan. I'll redo any commits needing attribution ASAP.
Comment #17
colanStill missing
--author
tag though?Comment #18
cfinke CreditAttribution: cfinke commentedDiscussing the need for an
--author
tag here: https://www.drupal.org/node/1389748#comment-12180388Comment #20
cfinke CreditAttribution: cfinke commented