Motivation

The goal is to permit to make request to antispam servers through the proxy, if Drupal is configure in this way.

Proposed resolution

Drupal give us the marvellous function drupal_http_request() which check if the proxy configuration is set for the current site. So, for implement this request we just have to modify _antispam_api_http_post() function for used this drupal_http_request() function.
(My patch coming soon...)

Remaining tasks

Your comments, about the patch will be posting in the next comment, are welcome ;)

User interface changes

No change.

API changes

- The variable name return by the function _antispam_api_http_post() have changed from $response to $return.
- The $return[0] isn't the same as former $response[0]. $response[0] just returned a string with the response headers. $return[0] return the whole object returned itself by drupal_http_request(). Better or worse ? I feel that better, but i'm open to your comments.
- The $return[1] is the same as former $response[1].

CommentFileSizeAuthor
#6 Use-drupal-configuration-proxy-1915116-6.patch8.38 KBchrisguindon
#5 Use-drupal-configuration-proxy-1915116-5.patch2.1 KBarunkumark
#2 antispam-use_drupal_configuration_proxy-1915116-2.patch1.99 KBMerkator
#1 antispam-use_drupal_configuration_proxy-1915116-1.patch26.17 KBMerkator
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Merkator’s picture

Merkator CreditAttribution: Merkator commented
Issue tags: +configuration, +drupal_http_request, +settings, +proxy, +_antispam_api_http_post
FileSize
antispam-use_drupal_configuration_proxy-1915116-1.patch26.17 KB

My patch... Your comments ? :)

Merkator’s picture

Merkator CreditAttribution: Merkator commented
FileSize
antispam-use_drupal_configuration_proxy-1915116-2.patch1.99 KB

My former patch is really bad. This one is better... Sorry.

NStorm’s picture

NStorm CreditAttribution: NStorm commented
Status: Active » Needs review

Will change it to "needs review" for patch test. But this package is unfortunately are unmaintained by now.

marcoscano’s picture

marcoscano
Primary language Portuguese, Brazil
Location Barcelona, Spain
CreditAttribution: marcoscano at Lullabot for Cisco Systems commented
Version: 7.x-1.5 » 7.x-1.x-dev
Issue summary: View changes
Status: Needs review » Needs work
Issue tags: -configuration, -drupal_http_request, -settings, -proxy, -_antispam_api_http_post +Needs reroll

Patch does not apply to -dev anymore. Also, some minor improvements to the patch:

  1. +++ b/antispam.module
@@ -2446,27 +2446,30 @@ function _antispam_api_build_query_string($array) {
+ * @return array Object returned by drupal_http_request in $return[0] and entity in $return[1].

    I know this was not created in this patch, but once we are modifying it, we could take the opportunity to apply the current coding standards to this docblock :)

    https://www.drupal.org/docs/develop/coding-standards/api-documentation-a... 

  2. +++ b/antispam.module
@@ -2446,27 +2446,30 @@ function _antispam_api_build_query_string($array) {
+  ¶

    There are some trailing spaces here. 

  3. +++ b/antispam.module
@@ -2446,27 +2446,30 @@ function _antispam_api_build_query_string($array) {
+  ¶

    There are some trailing spaces here. 

  4. +++ b/antispam.module
@@ -2446,27 +2446,30 @@ function _antispam_api_build_query_string($array) {
+  $response = drupal_http_request($url,$options);

    There should be a space between the comma and the next argument in the function call. 

  5. +++ b/antispam.module
@@ -2446,27 +2446,30 @@ function _antispam_api_build_query_string($array) {
+    $return = array();

    This assignment is redundant because $return was already assigned some lines before.

arunkumark’s picture

arunkumark
Location Coimbatore
CreditAttribution: arunkumark as a volunteer and at DrupalPartners for Innoppl Technologies Pvt. Ltd commented
Status: Needs work » Needs review
FileSize
Use-drupal-configuration-proxy-1915116-5.patch2.1 KB

Hi,

I have rerolled patch for the 7.x-1.x-dev version with comment #4.

chrisguindon’s picture

chrisguindon CreditAttribution: chrisguindon as a volunteer commented
FileSize
Use-drupal-configuration-proxy-1915116-6.patch8.38 KB

I have rerolled patch for the 7.x-1.x-dev version with comment #5

This patch is a bit larger since it's also removing some unwanted whitespaces in the file.

chrisguindon’s picture

chrisguindon CreditAttribution: chrisguindon as a volunteer commented
Issue tags: -Needs reroll