Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Upon initial installation I immediately get the following errors on a page load:
Notice: Undefined index: body in antispam_comment_presave() (line 1012 of all/modules/antispam/antispam.module).
Notice: Undefined index: mail in antispam_comment_presave() (line 1007 of all/modules/antispam/antispam.module).
Notice: Undefined index: ip in antispam_comment_presave() (line 1002 of all/modules/antispam/antispam.module).
Notice: Undefined index: body in antispam_comment_presave() (line 996 of all/modules/antispam/antispam.module).
Comment | File | Size | Author |
---|---|---|---|
#2 | antispam.module.patch | 1.57 KB | Reg |
Comments
Comment #1
Reg CreditAttribution: Reg commentedOops, I miss-spoke, not upon page load but on creating a comment.
Comment #2
Reg CreditAttribution: Reg commentedHere's a patch to get rid of the notices.
Comment #3
shabam CreditAttribution: shabam commentedI am getting this same error with the newest (1.5) version. I applied the patch (manually) and it works now.
Jason
Comment #4
Jody LynnThis could use another confirmation/review.
Comment #5
tim.plunkettThe !empty() didn't need to be added in addition to the original condition, it just need to replace it.
For example this should just be
if (!empty($antispambot_rules)) {
Comment #7
cfinke CreditAttribution: cfinke commentedComment #8
colan@cfinke: One thing to note:
--author
tag). This should definitely happen for #2379263: AKISMET service is not working with current 7.x DEV, possibly here, and wherever else. I mentioned that there, but as it's closed, you may not see it.Comment #11
colanStill missing
--author
tag though?Comment #12
cfinke CreditAttribution: cfinke commentedThe Drupal "commit messages" page says this about giving credit:
Is that not sufficient?
Comment #13
colanThat's great for humans, but for drupal.org to automatically credit authors so that commits show up in their profile, maintainers need to use the
--author
option when committing. This is noteworthy from the link above:This is pre-filled based on whoever submitted the last patch, but you may want to change it by selecting a different radio button if someone did more work in a previous patch, and you want to make him/her the author.
Comment #14
tim.plunkettThe --author flag does not control what shows up in the profiles. That would be the "credit" checkboxes, which are currently blank for this issue.
The project maintainer can select those checkboxes, and hit save.
No need to change the commit any futher.
Comment #15
colan#14: Correct! I forgot about that option because it's newer.