strpos error occurs when replying to an annotation [#895874]

warning: strpos() [function.strpos]: Empty delimiter in [path]\sites\all\modules\annotation\annotation_text\annotation_text.module on line 349.

Note: I applied the better_UI patch, but this error occurs in either case. This happens independently of content type - in any text based content that has annotation enabled.

Comments

Comment #1

baaj CreditAttribution: baaj commented 21 June 2012 at 21:36

The offending line is $pos = strpos($haystack, $needle);

  // get positions
  $pos = strpos($haystack, $needle);
  while ($pos !== FALSE) {
    $results[] = $pos;
    $pos = strpos($haystack, $needle, $pos + 1);
  }
  
  // find closest match
  if (count($results)) {
    $bestDiff = strlen($haystack) * 2; // extreme amount
    foreach ($results as $pos) {
      $diff = abs($target - $pos);
      if ($diff < $bestDiff) {
        $bestDiff = $diff;
        $bestPos = $pos;
      }
    }
  }
  
  return $bestPos; 
}

Comment #2

k3rr78nd CreditAttribution: k3rr78nd commented 10 May 2012 at 19:55

It looks like either $haystack or $needle is empty. I added one line to test for this which fixed the error for me:

 if($haystack && $needle){
  $pos = strpos($haystack, $needle);
  while ($pos !== FALSE) {
    $results[] = $pos;
    $pos = strpos($haystack, $needle, $pos + 1);
  }

  // find closest match
  if (count($results)) {
    $bestDiff = strlen($haystack) * 2; // extreme amount
    foreach ($results as $pos) {
      $diff = abs($target - $pos);
      if ($diff < $bestDiff) {
        $bestDiff = $diff;
        $bestPos = $pos;
      }
    }
  }
}

Sure there is a better way to do this but hey it's working for me so far ...