Closed (fixed)
Project:
Animated gif support for image styles
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Issue tags:
Reporter:
Created:
3 May 2016 at 13:32 UTC
Updated:
12 Feb 2017 at 11:58 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
artureiji commentedThough this might depend on fixing the gif-resizer library, I was able to resolve with ImageMagick as it easily solves the problem with success. Attached patch with solution.
Comment #3
artureiji commentedUpdating the patch code with better practices and standards.
Comment #4
a.gursoy commentedThank you for patch. It's working but sometime makes server cpu %200.
@artureiji Do you have this kind of problem?
Comment #6
denes.szabo commented@artureiji Thanks for the patch! Just committed your patch http://cgit.drupalcode.org/animgif_support/commit/?h=7.x-1.x&id=11c084fc...
I found few issues:
return $gr->resize($source_image, $resized_image, $width, $height);There was no $source_image, $resized_image variables in your function… The $gr->resize() returns nothing, so the image was not made at last if you used gifResizer lib. Both issue has fixed.
And please setup your editor for use the correct Drupal coding standards - was few indent issue after patching the original file.
But, thanks again! Btw, we need to test the whole animated gif generation with php-imagemagick, but without the animgif_support module. I suspect, if the imagemagick is present then no need this module at all can be disabled (so, no need imagick support to this module).
Comment #8
denes.szabo commentedSeems no feedback. Let's roll out a stable release to get feedback…
Comment #9
denes.szabo commented