Hi, first of all, thank you for this nice module.

I found a bug on image_animgif_save() that prevents the image of being delivered on the first hit of the image style.

The image_save function expects a return value from image_animgif_save() to be returned in order to tell its caller if the image was saved with success. The function image_animgif_save() does not return any value, therefore the core image module things that the image was not created (image_style_deliver()).

Comments

xthiago created an issue. See original summary.

xthiago’s picture

The attached patch fixes the issue.

  • Denes.Szabo committed 9d9c38c on 7.x-1.x authored by xthiago
    Issue #2706757 by xthiago: Missing return in an function prevents image...
denes.szabo’s picture

Status: Active » Closed (fixed)

Nice catch! Thank you!
And big welcome for your first commit on d.org! :)