Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The path which has been mentioned as below for typed js library
Please use command "drush dal" to download dependencies or manually download the repository https://github.com/mattboldt/typed.js/archive/master.zip into the libraries folder to define the following structure [DRUPAL_ROOT]/libraries/typedJS/typed.js-master/js/typed.js
After downloading library, I did not get any /js/typed.js file. As I understand, the correct file path should be [DRUPAL_ROOT]/libraries/typedJS/typed.js-master/src/typed.js, that should be corrected in module. Please correct me if I am wrong.
Comment | File | Size | Author |
---|---|---|---|
#14 | 2019-12-10_00-23-25.png | 45.9 KB | floown |
#12 | modify-library-path-because-of-composer-3011268-12.patch | 1.19 KB | arnaldop |
Comments
Comment #2
Devendra Mishra CreditAttribution: Devendra Mishra commentedComment #3
neuquen CreditAttribution: neuquen commentedI'm seeing the same issue.
As a temporary fix I changed the animations_dependencies.typedJS.file configration value within animations/config/install/animations.config.yml:
And then refreshed the config with drush:
drush cim -y --partial --source=modules/contrib/animations/config/install/
Comment #4
cobenashBecause of using composer, I think maybe the module should change the default library path.
The current library path is using "[DRUPAL_ROOT]/libraries/typedJS/typed.js-master/js/typed.js".
However, I think it should be "[DRUPAL_ROOT]/libraries/typedjs/src/typed.js" instead.
we can easily follow the default installer-path of drupal-library.
Comment #5
cobenashIn order to use composer download and manage library, I made a little change.
Comment #6
cobenash#2898824 mentioned before. The path of typejs has already been committed in to 8.x-1.x-dev.
However, it still not compatible with composer. So I made a little change on config.yml.
The patch is used to 8.x-1.x-dev version.
it can be installed via
composer require drupal/animations:1.x-dev
And Add the following line to the repositories of the composer.json file
and then use
composer require mattboldt/typedjs daneden/animatecss matthieua/wowjs
it will work perfectly. :)
Comment #7
cobenashComment #8
deggertsen CreditAttribution: deggertsen commentedDid everything according to #6, but libraries are all still showing up as missing. See attached screenshots.
Comment #9
vuilComment #10
arnaldopPatch for latest 8.x-1.2.
Comment #11
arnaldopNew patch. Sorry for the confusion.
Comment #12
arnaldopWell, what a fun morning of side tracks and tangents!
Here is a (hopefully) final patch for
8.x-1.2
.Included in this patch are:
master
versions of all of the libraries. This is a bad practice. Any change committed to master branch of those dependencies can break things, and no one has any control over it. People runningdrush dal
today can get totally different results tomorrow. So all of the versions are now fixed to the most recent release:This will also address the root complaint in https://www.drupal.org/project/animations/issues/2912546 and will also ensure that new downloads of this module won't break because the dependencies have new code in their
master
branches.Comment #13
arnaldopComment #14
floown CreditAttribution: floown commentedHello,
I have apply the patch, but the problem seems always to be here.
Comment #15
floown CreditAttribution: floown commentedI have try too with a:
composer require drupal/animations:1.x-dev
I have adapt to the latest zip, inspired from #6:
The libraries are downloaded, but the directories names are not good. I have rename them, but I have always the result like in my previous screenshot.
So, a solution for 1.2 or dev version?
Regards