Error when item is not set

Maybe it's better to get the File entity directory from the variables array and skip the usage of the getValue method?
See the patch I've made.

Came across this same issue, 6 fixed it but had PHPCS issues - this fixes those. I think this module could do with a few automated tests as well so adding a tag for that.

Thanks for the patches.
This week I'll try to find some time to review.

Hello,

Thanks everyone for reporting the issue and providing patches.

But can you please provide detailed steps to reproduce the issue starting from a fresh Drupal standard install?

Or what is the entity browser configuration and view listing?

Because I tried to reproduce the bug and I didn't manage to obtain the error.

When trying to browse for images using the Entity Browser (Entity Embed from Wysiwyg), I get an error when trying to read from the Media Library [Uploads work fine].

I'd expect to see the view listing of media images in the Media Library - but instead get an error message.

The website encountered an unexpected error. Please try again later.
Error: Call to undefined method stdClass::getValue() in animated_gif_preprocess_image_formatter() (line 18 of modules/contrib/animated_gif/animated_gif.module).

When I uninstall the Animated GIF module, I am able to browse for files again.

I've applied this patch #7 3056477-7.patch and it solves the issue. I was using 8.x-1.4

Thanks for the feedback.

Checking.

Sorry, but I still need detailed steps to reproduce the bug.

As in comment 10, it is written "from the Media Library", I don't know if this is still on Entity Browser or the core media library. So I tried with boths and it works in boths cases (without the patch), see attached screenshots.

Therefore, this still needs detailed steps to reproduce starting from a standard Drupal install.

The patch of #7 didn't work with 1.6.0 anymore, so i've created a new one based on the old patches.

Yeah this is still an issue. It happens for me on view lists of File entities.

Hello,

And it still requires detailed steps to reproduce from a fresh Drupal install.

I'm encountering a similar error but in a different scenario:

Error: Call to a member function getValue() on array in animated_gif_preprocess_image_formatter()

Anyway I think the solution for the error in the issue description would also solve that error I found. As for the patch in #14, I think that this won't be sufficient and is lacking a basic validation of whatever is inside $variables['item'] is actually an object or even is set at all. So maybe something like

if (empty($variables['item']) || $variables['item'] instanceof \Drupal\image\Plugin\Field\FieldType\ImageItem) {
  return;
}

would solve the error described in the IS as well as the one I'm encountering.

In my case, the steps to replicate this are the following (it includes other contribs, so not sure if it's a great example):

On Vanilla Drupal 9.5.x

1. $ drush si -y && drush en -y admin_toolbar_tools, media, component_library, media_library && drush uli
2. Add a media reference field to the article content type and make sure it's using the Media Library widget on the node form
3. Create an article node adding an image media in the media field
4. Enable the animated_gif module
5. Refer to the following screencast for further steps

Reroll patch for the last version.

Hi,

I tried to reproduce from the steps provided in comment 17.

No problem. I tried with image field, image field with entity browser, media field.

In this gif screencast you will see my entity browser view configuration.

I remember that for me I could reproduce with fields that have multiple fields, maybe entity reference with multiple images in the field, because in xdebug y showed an entitties array instead a single entity, for me the last patch worked

See the attached patch for a version which works with the 2.x branch.

I had been able to get the issue with Layout Builder preview.

When displaying a media entity reference field with the "Thumbnail" formatter.

Patch for Composer usage.

I think the problem is deeper and not necessarily related to animated_gif.

Because once there is no more fatal error, I still have plenty of warnings from Core codebase, so I guess there is an alteration somewhere that "destroys" expected input data.

Potentially related to #3170319: SVG-only image fields cause error with Layout Builder

I made the checks a bit more specific, as it didn't suffice for Layout Builder. The getValue() was still reached.

It would be even better if we could check the object class instead of presence of the getValue() method, but I don't know which one is expected.

I updated this to use method_exists instead of properties, because it is checking a method not a property.

Hello,

I have incorporated the changes proposed here in #3561824: Code update on new 2.x branch for a 2.2.0 release (not yet done). It was needed for PHPStan.

Keeping this issue opened if someone want/can provide tests.

With the refactoring done on 2.x this branch is not affected.

Will merge on 2.1.x and then release 2.1.1