Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Recently I was working on this module on a fresh site and encountered problems getting image styles working. Of course after a day of not being able to figure it out, I realized I hadn't applied the required core patch for image styles to work properly.
In the mean time I had posted a patch to make image styles work without a core patch as part of #2742253: Transfer files locally before generating derivatives (work-around for ImageMagick vulnerability mitigation). Now that we know this is possible, perhaps we should look into incorporating the parts of that issue that make it unnecessary to patch core.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | amazons3-no_core_patch-2743711.diff | 1.98 KB | quicksketch |
Comments
Comment #2
quicksketchComment #3
quicksketchSplitting out the change from #2742253: Transfer files locally before generating derivatives (work-around for ImageMagick vulnerability mitigation), this patch eliminates the need for a Drupal core patch.
Comment #4
quicksketchI created a PR with added tests at https://github.com/justafish/drupal_amazons3/pull/48.
Comment #5
Island Usurper CreditAttribution: Island Usurper commentedNever mind. I'm having trouble with the other core patch.
Comment #6
Island Usurper CreditAttribution: Island Usurper commented