aat_legacy fixes

While trying to use this module to migrate from the amazon associate tools on howigotengaged.com, I found the following set of errors.

There is a SQL error in the code. The "where" clause is specified multiple times:

  $sql = "SELECT * FROM {amazon_item_node} ain WHERE ain.nid = %d ORDER BY delta ASC WHERE ain.module = 'aat_legacy'";

I think it should be:

  $sql = "SELECT * FROM {amazon_item_node} ain WHERE ain.nid = %d AND ain.module = 'aat_legacy' ORDER BY delta ASC";

In the view hook, it attempts to call theme on $product which is never defined. In addition, the nested theme calls don't appear to behave correctly.

Attaching a patch, setting severity to critical b/c this bug blocks the modules use.

With these fixes and by fixing the null-able columns mentioned in http://drupal.org/node/353285 I have been able to get the legacy nodes to show up in a amazon item view, but am still struggling to view the old nodes. It appears that when viewing the nodes it is correctly pulling back the data from the API, but am still running into the following error:

Invalid argument supplied for foreach() in C:\twamp\htdocs\hig\sites\all\modules\cck\content.module on line 1284.

I will continue to troubleshoot as time allows.