Curious what the maintainers plans are for this module in Drupal 8? I've been working on the D8 port of AWS SDK in a sandbox (see also: #2677494: Drupal 8 port (and update to version 3.x of the AWS SDK)). At the moment, I need the Amazon filter so I was going to port that in a sandbox as well. And I'm happy to merge it into this project if there will be a D8 release or promote it as a solo project if there is no consensus.

Would love to hear if there are any plans in place and how I can help. Thanks!

Comments

mikeker created an issue. See original summary.

mikeker’s picture

mikeker commented
Status: Active » Needs review

Initial port of the Amazon Filter module to D8 can be found in this sandbox project. At the moment it's a pretty limited subset of the D7 filter module.

Again, I would appreciate any feedback from the maintainers as to their plans for a D8 port of this module. Please feel free to PM me via my contact for. (Bumping to NR for that reason.)

Or maybe we can meet for a beer (or coffee) in DC New Orleans! :)

kamescg’s picture

kamescg commented

I just uploaded the very unstable release of the Amazon Product Advertisement Drupal 8 version - https://www.drupal.org/node/3219/git-instructions/8.x-unstable1

As of now, I'm probably the only maintainer who is active and in a very minor way. Haven't checked the issues in several months and only barely began to port the module several weeks ago.

@mikeker
I'll check out the sandbox link you've provided and definitely take the time to merge both branches where possible.

What is the intended goal of the AWS SDK module? To mimic the Amazon Product Advertisement API module functionality or connect different services from Amazon?

Would you like maintainer status and to actively contribute to the module?

A coffee sounds great :) I'll let you know the next time I pass the New Orleans area or maybe let me know when you're in the Bay Area?

mikeker’s picture

mikeker commented

@kamescg, Thanks for the reply. The AWS SDK module is meant to access Amazon's web services (EC2, S3, bulk email, etc.). It just has a lot of similarities with the Amazon Product Advertisement API in terms of needing an API key/secret and calling Amazon's service endpoints.

Sorry, I should've linked to the sandbox port of this module instead. (Trying to do too many things at once!) So far it just handles a limited version of the amazon_filter as that's what I needed for my current project. As you can see, it's a pretty rough port/rewrite at the moment and it does have a fair bit of refactoring going on. I guess my first question is whether you're open to this sort of approach -- a refactor/rewrite rather than a direct port?

I'll ping you by email to discuss further.

kamescg’s picture

kamescg commented

I think a rewrite would be the appropriate direction and I'm very happy you're interested in contributing :)

I'll admit my attempt is more of a direct port, simply because I was learning Drupal 8 and OOP, which I am unfamiliar with (except for theory) at the moment. Obviously I would like to clean up the files for best practices like incorporating the request interface and caching.

In addition, I've started to develop the Amazon Store module, which is responsible for providing an out-of-the-box solution for setting up an Amazon Store if you would like to contribute to that as well.

giorgio79’s picture

giorgio79 commented

@kamescg : Perhaps you could use an already existing Symfony plugin for the Product Advertising API at https://packagist.org/packages/exeu/apai-io

mikeker’s picture

mikeker commented
Assigned: Unassigned » mikeker

@giorgio79: Very interesting, thanks for the link! I'll look into it shortly.

mikeker’s picture

mikeker commented
Assigned: mikeker » Unassigned

We are now using the Apai-IO library (via Composer). See: #2711041: Use Composer and Packagist to download API SDK. I pushed this to a new 8.x-2.x branch so it doesn't interfere with work @kamescg is also doing. We'll need to merge these two approaches sometime soon...

mingsong’s picture

mingsong
Location 🇦🇺
commented

Thank mikeker for you works.

I recently develop a patch (https://www.drupal.org/node/2841941#comment-11882615) based on branch 8.x-2.x where I develop following new features and come with a bug fixing (https://www.drupal.org/node/2787145).

  1. Support multiple Associates IDs (multiple country)
  2. Add browseNodeLookup function

I did a quick test with the latest version of Drupal 8. It is working well with my custom module.

Please be aware that this patch works with apai-io version 2.0 not 1.0 and need to get the composer of 'exeu/apai-io' installed in folder \vendor not in \modules\contrib\amazon\vendor

web226’s picture

web226 commented

Hi, where do i get 8.x-2.x? I can't find it available anywhere. Thanks!

To answer my own question, I found it in your comment here: https://www.drupal.org/node/2841941#comment-11882615

mingsong’s picture

mingsong
Location 🇦🇺
commented

Hi web226,

You can clone the branch by git from following page

https://www.drupal.org/node/3219/git-instructions/8.x-2.x/nonmaintainer