For multi-value Amazon Item fields using the Amazon ASIN Text field widget, asin_field_widget_element_validate() is called once for each field shown on the add/edit form. For each call it iterates over each field on the form, validating each field multiple times and causing redundent lookups.

The attached patch addresses the issue, and seems to properly catch invalid input in all submitted fields.

It also addresses the issue where such validations would cause PHP 5.4 and newer to throw the following warning:
Warning: Illegal string offset 'asin' in asin_field_widget_element_validate() (line 212 of /path/to/drupal/sites/all/modules/amazon/asin/asin.module).

The above behavior is documented here:
http://docs.php.net/manual/da/language.types.array.php

CommentFileSizeAuthor
#2 amazon-asin_field_widget_element_validate_causes_redundent_lookups-2317539-2.patch1.37 KBgeneralredneck
asin.module.patch1.27 KBbrucebertrand

Comments

smitty’s picture

smitty commented

This patch seems to work fine. At least the Warning "Illegal string offset" disappears ...

My only problem was: the patch sems to be coded in the wrong direction. I think it should be:

-  foreach ($form_state['values'][$field_name][$langcode] as $delta => &$item) {
-    $asin = trim(amazon_convert_to_asin($item['asin']));
-    if (!empty($asin) && is_numeric($delta)) {
-      $results = amazon_item_lookup(array($asin));
-      if (empty($results)) {
-        form_set_error("{$field_name}][{$langcode}][{$delta}][asin", t('No Amazon product with the ASIN "%id" could be located.', array('%id' => $asin)));
-      }
-      else {
-        $item['asin'] = (string)key($results);
-      }
+  $delta = $element['#delta'];
+  $item =& $form_state['values'][$field_name][$langcode][$delta];
+
+  $asin = trim(amazon_convert_to_asin($item['asin']));
+  if (!empty($asin) && is_numeric($delta)) {
+    $results = amazon_item_lookup(array($asin));
+    if (empty($results)) {
+      form_set_error("{$field_name}][{$langcode}][{$delta}][asin", t('No Amazon product with the ASIN "%id" could be located.', array('%id' => $asin)));
+    }
+    else {
+      $item['asin'] = (string)key($results);
generalredneck’s picture

generalredneck
him/his
Primary language English
Location Texas, USA 🇺🇸
commented
StatusFileSize
new amazon-asin_field_widget_element_validate_causes_redundent_lookups-2317539-2.patch1.37 KB

You are right, I was able to get it to apply with patch -p1 -R < asin.module_0.patch. Additionally the patch had to be applied inside the asin module directory where typically on projects such as this one with multiple modules, you create/apply at the project level so that git, drush, and composer can all work with the patches in an automated way. Attaching the corrected patch.

Thank you for the work!

marcelovani’s picture

marcelovani
Primary language Portuguese, Brazil
Location London
commented
Version: 7.x-1.1 » 7.x-1.x-dev
Status: Patch (to be ported) » Needs review