Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
[COMMIT_HASH]
3386ffd153a2a96682f22def18b0cf25625880d5
[RESULTS_OUTPUT]
------ -----------------------------------------------------------------------------------
Line src/Tests/AllowedFormatsTest.php
------ -----------------------------------------------------------------------------------
63 Call to deprecated method strtolower() of class Drupal\Component\Utility\Unicode.
71 Call to deprecated method strtolower() of class Drupal\Component\Utility\Unicode.
------ -----------------------------------------------------------------------------------
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
Comment | File | Size | Author |
---|---|---|---|
#11 | 3042686-11.patch | 2.18 KB | idebr |
| |||
#11 | interdiff-10-11.txt | 391 bytes | idebr |
Comments
Comment #2
zrhoffman CreditAttribution: zrhoffman as a volunteer commentedWe are supposed to be using
mb_strtolower()
now (see comment).Comment #3
zrhoffman CreditAttribution: zrhoffman as a volunteer commentedComment #4
zrhoffman CreditAttribution: zrhoffman as a volunteer commentedComment #5
waverate CreditAttribution: waverate commentedPatch at #2 works. Thank you @zrhoffman.
Comment #6
idebr CreditAttribution: idebr at ezCompany commented./src/Tests/AllowedFormatsTest.php
now contains an unused use statement:Comment #7
beram CreditAttribution: beram as a volunteer and at Ekino commentedTaking into account the comment #6
Comment #8
idebr CreditAttribution: idebr at iO commentedPatch applies cleanly and fixes the reported Drupal 9 incompatibilities.
Comment #9
BerdirThis is making changes to a simpletest, which is deprecated and needs to be converted to a functional test.
We should also use the new core_version_requirement in info.yml.
Comment #10
idebr CreditAttribution: idebr at iO commentedAttached patch converts the Simpletest to a PHPUnit based BrowserTestBase.
Comment #11
idebr CreditAttribution: idebr at iO commented#9.2 Added the core_version_requirement key to the info.yml file
Comment #12
BerdirLooks fine to me, no deprecation messages left when running the test. I'll leave it to the maintainer to decide if a composer.json should be included so we don't have to wait on d.o infrastructure per the note in https://www.drupal.org/node/3070687.
Comment #14
floretan CreditAttribution: floretan at Wunder commentedThank you for these changes. I'll take a look at adding a composer.json.
Comment #15
BerdirNote that adding a composer.json is no longer required, d.o now does generate it correctly.
Comment #17
pianomansam CreditAttribution: pianomansam commentedDrupal 9 is out! Can we have this update in a full release?