Problem/Motivation

[COMMIT_HASH]

3386ffd153a2a96682f22def18b0cf25625880d5

[RESULTS_OUTPUT]

------ -----------------------------------------------------------------------------------
Line src/Tests/AllowedFormatsTest.php
------ -----------------------------------------------------------------------------------
63 Call to deprecated method strtolower() of class Drupal\Component\Utility\Unicode.
71 Call to deprecated method strtolower() of class Drupal\Component\Utility\Unicode.
------ -----------------------------------------------------------------------------------

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Adrianm6254 created an issue. See original summary.

zrhoffman’s picture

FileSize
930 bytes

We are supposed to be using mb_strtolower() now (see comment).

zrhoffman’s picture

Assigned: Unassigned » zrhoffman
Status: Active » Needs review
zrhoffman’s picture

Issue tags: +Seattle2019
waverate’s picture

Status: Needs review » Reviewed & tested by the community

Patch at #2 works. Thank you @zrhoffman.

idebr’s picture

Status: Reviewed & tested by the community » Needs work

./src/Tests/AllowedFormatsTest.php now contains an unused use statement:

use Drupal\Component\Utility\Unicode;
beram’s picture

Status: Needs work » Needs review
FileSize
1.14 KB
422 bytes

Taking into account the comment #6

idebr’s picture

Assigned: zrhoffman » Unassigned
Status: Needs review » Reviewed & tested by the community

Patch applies cleanly and fixes the reported Drupal 9 incompatibilities.

Berdir’s picture

Status: Reviewed & tested by the community » Needs work

This is making changes to a simpletest, which is deprecated and needs to be converted to a functional test.

We should also use the new core_version_requirement in info.yml.

idebr’s picture

Status: Needs work » Needs review
FileSize
1.04 KB
1.8 KB

Attached patch converts the Simpletest to a PHPUnit based BrowserTestBase.

idebr’s picture

FileSize
391 bytes
2.18 KB

#9.2 Added the core_version_requirement key to the info.yml file

Berdir’s picture

Status: Needs review » Reviewed & tested by the community

Looks fine to me, no deprecation messages left when running the test. I'll leave it to the maintainer to decide if a composer.json should be included so we don't have to wait on d.o infrastructure per the note in https://www.drupal.org/node/3070687.

  • idebr authored 4aac014 on 8.x-1.x
    Issue #3042686 by idebr, beram, zrhoffman, Berdir: Drupal 9 Deprecated...
floretan’s picture

Status: Reviewed & tested by the community » Fixed

Thank you for these changes. I'll take a look at adding a composer.json.

Berdir’s picture

Note that adding a composer.json is no longer required, d.o now does generate it correctly.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

pianomansam’s picture

Drupal 9 is out! Can we have this update in a full release?