Issue 1.
If two keyword are present and if one key word is a super set of the other the rendering is not done correctly
eg 1> keyword1 :- Hello
2> keyword2 :- Hello World
If the text as the word "hello world" it replaces it with the url present in hello and not the one present in hello world
Issue 2
If suppose the url of one of the keywords as a word which is a keyword it tries to insert an anchor within another anchor does resulting in an error
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | alinks-Improper-conversion-of-links-3062181-4.patch | 4.41 KB | mukundhraj |
| #3 | alinks-Improper-conversion-of-links-3062181-3.patch | 2.44 KB | mukundhraj |
Comments
Comment #2
mukundhraj commentedComment #3
mukundhraj commentedComment #4
mukundhraj commentedComment #5
neppolian commentedComment #6
osopolar#4 looks complicated, wouldn't it be enough to just sort the keywords descending by length and start replacement with the longest keyword? As
length("Hello World") > length("Hello")this should result in replacing first "Hello World" and if there is somewhere a "Hello" left, then it might be replaced too.@mukundhraj: What do you think? Am I missing something?