Problem/Motivation

The settings screen contains a checkbox labeled "Enable testing mode". This lets Akismet know you are testing by setting the is_test input (see https://akismet.com/development/api/#detailed-docs, heading "Testing your API calls"). However, this is now what the description says; "Submitting "ham", "unsure", or "spam" triggers the corresponding behaviour; image CAPTCHAs only respond to "correct" and audio CAPTCHAs only respond to "demo". Do not enable this option if this site is publicly accessible." This is a direct copy of the text from the Mollom module. The text is misleading in case of Akismet.

Proposed resolution

Change the description to "Let Akismet know you are testing and do not train the algorithm based on your inputs. Refer to the Akismet documentation for triggering guaranteed spam responses (regardless of using test mode)."

Remaining tasks

  • Make change
  • Augment tests, make sure there is a test that checks for the is_test input for the API
  • Submit MR
  • Review
  • Commit

User interface changes

Changes to microcopy with the testing mode option.

API changes

None.

Data model changes

None.

Issue fork akismet-3075149

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

eelkeblok created an issue. See original summary.

eelkeblok’s picture

eelkeblok
he/him
Primary language Dutch
Location Netherlands 🇳🇱
commented
Issue tags: +Needs issue summary update

While working on #3198393: Automated tests are currently failing I realised the test mode checkbox does do something; it enables the is_test input passed to the Akismet API (see https://akismet.com/development/api/#detailed-docs, heading "Testing your API calls"). This is probably a good approach, combined with the documented inputs to force spam responses. The description of the checkbon in the settings is misleading, though, and does not properly explain what it does. It should explain that it lets Akismet know you are testing, and should explain what it does "Let Akismet know you are testing and do not train the algorithm based on your inputs. Refer to the Akismet documentation for triggering guaranteed spam responses (regardless of using test mode)."

eelkeblok’s picture

eelkeblok
he/him
Primary language Dutch
Location Netherlands 🇳🇱
commented
Title: Checkbox "Enable testing mode" does not do anything » Correct explanation of "Enable testing mode" checkbox
Issue summary: View changes

Updated IS.

eelkeblok opened merge request !10

eelkeblok’s picture

eelkeblok
he/him
Primary language Dutch
Location Netherlands 🇳🇱
commented
Related issues: +#3225042: Rework testing mode test
eelkeblok’s picture

eelkeblok
he/him
Primary language Dutch
Location Netherlands 🇳🇱
commented
Status: Active » Needs review

I'm pushing the test adjustment to #3225042: Rework testing mode test, since it will involve some refactoring of the client code.

  • eelkeblok committed 7e46d3c on 8.x-1.x 
    Issue #3075149 by eelkeblok: Correct explanation of "Enable testing mode...
eelkeblok’s picture

eelkeblok
he/him
Primary language Dutch
Location Netherlands 🇳🇱
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.