We ran into this on Drupal.org when trying to use the action with Views bulk operations.

From https://api.drupal.org/api/drupal/modules%21system%21system.api.php/func...

If no save action is present, one will be added.

This is indeed how the action is handled. After the db_update("node") runs, the node entities are saved, along with their unchanged published property.

Instead, I think it is best to work with this system, and set the published status on the entity and let the actions infrastructure take care of the rest. It is more simple code for Mollom.

CommentFileSizeAuthor
#22 2590101.patch1.44 KBdrumm
#16 2590101-16.diff1.47 KBB_man
#13 2590101.diff1.42 KBdrumm
#7 2590101.diff804 bytesdrumm
#2 2590101.diff592 bytesdrumm
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

drumm created an issue. See original summary.

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm at Drupal Association commented
Status: Active » Needs review
FileSize
2590101.diff592 bytes

Attached is a patch to fix this.

Status: Needs review » Needs work

The last submitted patch, 2: 2590101.diff, failed testing.

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm at Drupal Association commented
Related issues: +#2254871: Default action behaviors in getAccessMask()

#2254871: Default action behaviors in getAccessMask() could be the root cause here.

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm at Drupal Association commented
Status: Needs work » Closed (works as designed)

#2254871: Default action behaviors in getAccessMask() is definitely the root cause.

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm at Drupal Association commented
Status: Closed (works as designed) » Active

I realized this is only updating the {node}.status column, but not the {node_revision}.status column. node_load() gets the object's status from {node_revision}.status, so the nodes were unpublished in listings, but not unpublished on the individual node pages. We didn't notice this until now because we usually delete the nodes shortly after.

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm at Drupal Association commented
FileSize
2590101.diff804 bytes

The attached patch uses the action API's 'behavior' => array('changes_property') to do the node save when the action is done.

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm at Drupal Association commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 7: 2590101.diff, failed testing.

The last submitted patch, 7: 2590101.diff, failed testing.

The last submitted patch, 7: 2590101.diff, failed testing.

The last submitted patch, 7: 2590101.diff, failed testing.

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm at Drupal Association commented
Status: Needs work » Needs review
FileSize
2590101.diff1.42 KB

I confirmed this works using /admin/content's core bulk operation, and double checked the Views Bulk Operations UI works as well.

This updates the test to do the node save, as actions-calling code is expected to do.

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm at Drupal Association commented
Assigned: drumm » Unassigned
drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm at Drupal Association commented
Issue tags: -affects drupal.org
B_man’s picture

B_man
he/him
Location California, USA
CreditAttribution: B_man at Drupal Association commented
Project: Mollom » Akismet (Mollom replacement)
Version: 7.x-2.x-dev »
FileSize
2590101-16.diff1.47 KB

Updating this patch for Akismet.

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm at Drupal Association commented
Title: "Report node to Mollom as spam and unpublish" action should properly unpublish » "Report node to Akismet as spam and unpublish" action should properly unpublish
B_man’s picture

B_man
he/him
Location California, USA
CreditAttribution: B_man at Drupal Association commented

Backed this patch out as it seem to break functionality on d.o.

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm at Drupal Association commented
Status: Needs review » Closed (cannot reproduce)

Yes, seems this is no longer needed.

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm at Drupal Association commented
Assigned: Unassigned » drumm
Status: Closed (cannot reproduce) » Needs work

Turns out we do need this #3069572: "Report node to Akismet as spam and unpublish" does not unpublish

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm at Drupal Association commented
Project: Akismet (Mollom replacement) » Akismet
Version: » 7.x-2.x-dev
drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm at Drupal Association commented
Status: Needs work » Needs review
FileSize
2590101.patch1.44 KB

Fresh port of #13 to the new project.

gisle’s picture

gisle
he/him
Primary language Norwegian Bokmål
Location Norway
CreditAttribution: gisle at Hannemyr Nye Medier AS commented
Status: Needs review » Reviewed & tested by the community

Just unpublished a spam node using the "Report node to Akismet as spam and unpublish" menu item. It did unpublish the node with no extra step required.

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented
Issue tags: +affects drupal.org