I've been using the ajax_trigger module and am very pleased with the functionality and operation. I did find a problem with the use of 'select' fields, and have resolved the issue in the ajax_trigger.js code. Along the way I also added a few code fixes and optimized the module so that it doesn't blindly add all the ajax-able fields to all of the forms.

I've attached revised versions of the module components in a tar file rather than just posting patches to the code (I reformatted some of the code, and the differences due to white-space changes would make a patch unwieldy.)

Specific changes to the module are as follows:

  • Minor correction to the validation function for the timeout value.
  • Added 'select' items to the ajax-able field types.
  • Only add javascript events when fields are actually present.
  • Only add ajax to forms that contain ajax-able fields.
  • Created a function to detect ajax-able fields in a form.

I hope these changes are at least somewhat useful...

CommentFileSizeAuthor
ajax_trigger.tgz3.63 KBPaulHruska

Comments

kenorb’s picture

Status: Needs review » Fixed

Very nice improvements. Thank you.

Commited.
http://drupal.org/cvs?commit=328902

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.