Problem/Motivation

https://www.drupal.org/project/ai/issues/3538476 will introduces a new change where filters attribute will be updated from string to mixed.

Proposed resolution

Change the string $filters = '' param in querySearch() and vectorSearch() to accept mixed type.

Issue fork ai_vdb_provider_sqlite-3549485

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

gxleano created an issue. See original summary.

gxleano’s picture

gxleano commented
Status: Active » Needs review

gxleano opened merge request !3

gxleano’s picture

gxleano commented
Version: 1.1.x-dev » 1.0.0
jimyhuang’s picture

jimyhuang commented
Version: 1.0.0 » 1.1.x-dev
Status: Needs review » Needs work

Hello there,

I can't merge this pull request because you committed much more then your proposed solution.
Could you make a cleaner commit, and fire another pull request again?
It should only have 2 lines which replace "string" to "mixed", and keep the indentation.

And please also commit to the 1.1.x which is dev branch that will be next stable version. Thank you.