Problem/Motivation

In #3523510: 'Special Fields' created by Search API for Views are not actually fields and cannot be applied as Milvus conditions we limited milvus conditions to fields added via add fields screen, but this then stops the drupal_entity_id/drupal_long_id fields from working. The filter is silently not added and so a filter for a specific ID then returns all results instead.

Steps to reproduce

Add filter for drupal_entity_id. Get far more than requested.

Proposed resolution

Fix condition building logic

Remaining tasks

MR

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Issue fork ai_vdb_provider_milvus-3557314

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

scott_euser created an issue. See original summary.

scott_euser opened merge request !25

scott_euser’s picture

scott_euser commented
Status: Active » Needs review
scott_euser’s picture

scott_euser commented

Tests failing because #3552884: Move out AI Search is now in place

gxleano’s picture

gxleano commented

It looks good to me Scott!

But we would need to wait merging until the problem with AI Search package is resolved.

gxleano’s picture

gxleano commented
Status: Needs review » Reviewed & tested by the community

  • scott_euser committed abeed224 on 2.0.x 
    feat: #3557314 Lookup by drupal_entity_id/drupal_long_id returns all...
scott_euser’s picture

scott_euser commented
Status: Reviewed & tested by the community » Fixed

Thanks! Merged now that its green again

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

scott_euser opened merge request !37

scott_euser changed the visibility of the branch 3557314-backport-filter-fix to hidden.

scott_euser changed the visibility of the branch 3557314-backport-filter-fix to active.

scott_euser opened merge request !38

scott_euser changed the visibility of the branch 3557314-backport-filter-fix to hidden.

scott_euser’s picture

scott_euser commented

Backported to 1.1.x