While I worked on #3414579: Blocks cause WSOD; Cannot generate default URL last night several test errors occurred that seemed to be unrelated. It occurred to me that additional changes to Core may have broken Aggregator's tests. After all, it wouldn't be the first time in the last 24hrs that we've discovered a change in Core broke Aggregator. So I ran the pipeline this morning, https://git.drupalcode.org/project/aggregator/-/jobs/657134. Sure enough, our tests which were all passing now fail.

#3414579 deals with the fifth failure shown below. We may have to commit it as-is. The only thing that gives me pause is that two additional failures showed up in that issue's pipeline that aren't shown in the output below. The wrong number of blocks upgraded from D6/7 were incorrect. But that pipeline didn't show the D6/7 "Congratulations, you upgraded Drupal!" text failure that's shown below. My assumption is that the block issue is preventing the upgrade from completing successfully here. But that problem is fixed in the #3414579 pipeline; it simply needs the upgraded block count to be updated. So again, we probably have to commit #3414579 without it completely passing tests.

Failures:

1) Drupal\Tests\aggregator\Functional\AggregatorRenderingTest::testBlockLinks
Behat\Mink\Exception\ResponseTextException: The text "feed-pjynzw2lv3" was not found anywhere in the text of the current page.
/builds/project/aggregator/vendor/behat/mink/src/WebAssert.php:907
/builds/project/aggregator/vendor/behat/mink/src/WebAssert.php:293
/builds/project/aggregator/tests/src/Functional/AggregatorRenderingTest.php:60
/builds/project/aggregator/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
2) Drupal\Tests\aggregator\Functional\ItemCacheTagsTest::testEntityCreation
TypeError: Drupal\Tests\system\Functional\Entity\EntityCacheTagsTestBase::verifyRenderCache(): Argument #1 ($keys) must be of type array, string given, called in /builds/project/aggregator/tests/src/Functional/ItemCacheTagsTest.php on line 75
/builds/project/aggregator/web/core/modules/system/tests/src/Functional/Entity/EntityCacheTagsTestBase.php:647
/builds/project/aggregator/tests/src/Functional/ItemCacheTagsTest.php:75
/builds/project/aggregator/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
3) Drupal\Tests\aggregator\Functional\migrate_drupal_ui\d6\UpgradeTest::testUpgrade
Behat\Mink\Exception\ResponseTextException: The text "Congratulations, you upgraded Drupal!" was not found anywhere in the text of the current page.
/builds/project/aggregator/vendor/behat/mink/src/WebAssert.php:907
/builds/project/aggregator/vendor/behat/mink/src/WebAssert.php:293
/builds/project/aggregator/tests/src/Functional/migrate_drupal_ui/MigrateUpgradeExecuteTestBase.php:76
/builds/project/aggregator/tests/src/Functional/migrate_drupal_ui/MigrateUpgradeExecuteTestBase.php:30
/builds/project/aggregator/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
4) Drupal\Tests\aggregator\Functional\migrate_drupal_ui\d7\UpgradeTest::testUpgrade
Behat\Mink\Exception\ResponseTextException: The text "Congratulations, you upgraded Drupal!" was not found anywhere in the text of the current page.
/builds/project/aggregator/vendor/behat/mink/src/WebAssert.php:907
/builds/project/aggregator/vendor/behat/mink/src/WebAssert.php:293
/builds/project/aggregator/tests/src/Functional/migrate_drupal_ui/MigrateUpgradeExecuteTestBase.php:76
/builds/project/aggregator/tests/src/Functional/migrate_drupal_ui/MigrateUpgradeExecuteTestBase.php:30
/builds/project/aggregator/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
5) Drupal\Tests\aggregator\Kernel\Plugin\Block\AggregatorFeedBlockTest::testRenderBadItemUrl
Drupal\Core\Entity\Exception\UndefinedLinkTemplateException: Cannot generate default URL because no link template 'canonical' or 'edit-form' was found for the 'aggregator_item' entity type
/builds/project/aggregator/web/core/lib/Drupal/Core/Entity/EntityBase.php:176
/builds/project/aggregator/src/Plugin/Block/AggregatorFeedBlock.php:165
/builds/project/aggregator/tests/src/Kernel/Plugin/Block/AggregatorFeedBlockTest.php:63
/builds/project/aggregator/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

Issue fork aggregator-3415571

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dcam created an issue. See original summary.

dcam’s picture

dcam commented
Related issues: -#3414579: Blocks cause WSOD; Cannot generate default URL

Removed the related issue since I declared that to be a child of this issue.

dcam opened merge request !14

dcam’s picture

dcam commented

I've applied the quick-fix to the blocks: specifying the canonical link template in toUrl(). This will allow us to see if the #3414579: Blocks cause WSOD; Cannot generate default URL change really does fix the "Congratulations, you upgraded Drupal!" failures shown here. Then we'll have greater confidence that the other issue's MR should be merged.

dcam’s picture

dcam commented

This issue's branch was rebased from 2.x since the block fix was committed. Here's the updated list of failures:

1) Drupal\Tests\aggregator\Functional\AggregatorRenderingTest::testBlockLinks
Behat\Mink\Exception\ResponseTextException: The text "feed-pjr4bka2jv" appears in the text of this page, but it should not.
/builds/project/aggregator/vendor/behat/mink/src/WebAssert.php:907
/builds/project/aggregator/vendor/behat/mink/src/WebAssert.php:312
/builds/project/aggregator/tests/src/Functional/AggregatorRenderingTest.php:84
/builds/project/aggregator/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
2) Drupal\Tests\aggregator\Functional\ItemCacheTagsTest::testEntityCreation
TypeError: Drupal\Tests\system\Functional\Entity\EntityCacheTagsTestBase::verifyRenderCache(): Argument #1 ($keys) must be of type array, string given, called in /builds/project/aggregator/tests/src/Functional/ItemCacheTagsTest.php on line 75
/builds/project/aggregator/web/core/modules/system/tests/src/Functional/Entity/EntityCacheTagsTestBase.php:647
/builds/project/aggregator/tests/src/Functional/ItemCacheTagsTest.php:75
/builds/project/aggregator/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
--
There were 2 failures:
1) Drupal\Tests\aggregator\Functional\migrate_drupal_ui\d6\UpgradeTest::testUpgrade
Failed asserting that two arrays are identical.
--- Expected
+++ Actual
@@ @@
 Array &0 (
     'aggregator_feed' => 1
     'aggregator_item' => 1
-    'block' => 36
+    'block' => 37
     'entity_view_display' => 58
     'entity_view_mode' => 14
     'view' => 16
 )
/builds/project/aggregator/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:121
/builds/project/aggregator/vendor/phpunit/phpunit/src/Framework/Constraint/IsIdentical.php:79
/builds/project/aggregator/tests/src/Functional/migrate_drupal_ui/MigrateUpgradeExecuteTestBase.php:90
/builds/project/aggregator/tests/src/Functional/migrate_drupal_ui/MigrateUpgradeExecuteTestBase.php:30
/builds/project/aggregator/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
2) Drupal\Tests\aggregator\Functional\migrate_drupal_ui\d7\UpgradeTest::testUpgrade
Failed asserting that two arrays are identical.
--- Expected
+++ Actual
@@ @@
 Array &0 (
     'aggregator_feed' => 1
     'aggregator_item' => 10
-    'block' => 27
+    'block' => 28
     'entity_view_display' => 35
     'entity_view_mode' => 13
     'view' => 16
 )
/builds/project/aggregator/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:121
/builds/project/aggregator/vendor/phpunit/phpunit/src/Framework/Constraint/IsIdentical.php:79
/builds/project/aggregator/tests/src/Functional/migrate_drupal_ui/MigrateUpgradeExecuteTestBase.php:90
/builds/project/aggregator/tests/src/Functional/migrate_drupal_ui/MigrateUpgradeExecuteTestBase.php:30
/builds/project/aggregator/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
dcam’s picture

dcam commented

The verifyRenderCache() error is related to this CR: https://www.drupal.org/node/3354596.

larowlan made their first commit to this issue’s fork.

  • dcam committed 688f8592 on 2.x 
    Issue #3415571 by dcam, larowlan: Drupal 10.2.3-dev breaks Aggregator...
dcam’s picture

dcam commented
Status: Active » Fixed

Teamwork for the win. Thank you again, @larowlan!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.