------ --------------------------------------------------- 
  Line   src/Form/DeleteJob.php                             
 ------ --------------------------------------------------- 
  72     Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Form/QueueForm.php                             
 ------ --------------------------------------------------- 
  170    Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Form/ReleaseJob.php                            
 ------ --------------------------------------------------- 
  72     Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ ---------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   src/Plugin/AdvancedQueue/Backend/BackendInterface.php                                                                                                           
 ------ ---------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  18     Interface Drupal\advancedqueue\Plugin\AdvancedQueue\Backend\BackendInterface extends deprecated interface Drupal\Component\Plugin\ConfigurablePluginInterface.  
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------------
CommentFileSizeAuthor
#5 3092654-5-fix-deprecated.patch4.41 KBbojanz
#4 3092654-4.patch3.58 KBSahana _N
#2 deprecated-3092654-2.patch2.7 KBSergiu Stici
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Sergiu Stici created an issue. See original summary.

Sergiu Stici’s picture

Sergiu Stici CreditAttribution: Sergiu Stici at FFW commented
Status: Active » Needs review
FileSize
deprecated-3092654-2.patch2.7 KB

Here's the patch, please review.

bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Title: Deprecated Code Report » Remove usage of deprecated code
Status: Needs review » Needs work

Thank you for your work!

+    $this->messenger()->addMessage($this->t('Saved the %label queue.', ['%label' => $this->entity->label()]));

Let's use addStatus() instead of addMessage(). It's the more common version in core.

We also need to replace the setExpectedException() calls with expectException() and expectExceptionMessage() like we did in Commerce: #3089027: Replace the deprecated PHPUnit 4 setExpectedException() method usage.

Sahana _N’s picture

Sahana _N CreditAttribution: Sahana _N at Specbee commented
Status: Needs work » Needs review
FileSize
3092654-4.patch3.58 KB

Created the patch as per the suggestions please review the patch.

bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Title: Remove usage of deprecated code » Remove usage of deprecated code, allow installation on D9
FileSize
3092654-5-fix-deprecated.patch4.41 KB

Let's do this.

  • bojanz committed 0a8b326 on 8.x-1.x 
    Issue #3092654 by Sergiu Stici, bojanz: Remove usage of deprecated code...
bojanz’s picture

bojanz CreditAttribution: bojanz at Centarro commented
Status: Needs review » Fixed

The D9 build is failing, but it doesn't look like it's our fault. Let's proceed with the patch as-is and then open a followup if problems persist.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.