I wrote the existing README a few months back and have since expanded my knowledge since then. The README should line break at 80 characters and has a node alias that should be replaced with a permalink.

Thanks for your patience with my learning curve.

Patch to follow.

CommentFileSizeAuthor
#5 advanced_help-fix-readme-2899117-5.patch2.7 KBloopduplicate
#4 advanced_help-fix-readme-2899117-4.patch3.07 KBvolkswagenchick
#2 advanced_help-fix-README-2899117-2.patch3.09 KBvolkswagenchick
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

volkswagenchick created an issue. See original summary.

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
CreditAttribution: volkswagenchick at Hook 42 commented
Assigned: volkswagenchick » Unassigned
Status: Needs work » Needs review
FileSize
advanced_help-fix-README-2899117-2.patch3.09 KB

I have uploaded a patch that aligns closer to drupal.org standards.

Thanks!

loopduplicate’s picture

loopduplicate
she/her
Location Burning Token, California
CreditAttribution: loopduplicate at Hook 42 commented

Looks great but I have one question:

+++ b/README.txt
@@ -28,19 +33,27 @@ This module has no required dependencies outside of Drupal core.
+* Advanced help hint - (https://www.drupal.org/project/advanced_help_hint)

Should this line be reformatted to match the README template?
See https://www.drupal.org/docs/develop/documenting-your-project/readme-temp...
So, it would change to "Advanced help hint (https://www.drupal.org/project/advanced_help_hint):"

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
CreditAttribution: volkswagenchick at Hook 42 commented
FileSize
advanced_help-fix-readme-2899117-4.patch3.07 KB

uploaded a patch reflecting the suggested edits.

loopduplicate’s picture

loopduplicate
she/her
Location Burning Token, California
CreditAttribution: loopduplicate at Hook 42 commented
FileSize
advanced_help-fix-readme-2899117-5.patch2.7 KB

Looks good but the patch you created doesn't apply for some reason. I'm uploading a new one.

volkswagenchick’s picture

volkswagenchick
she/her
Primary language English
Location San Francisco Bay Area
CreditAttribution: volkswagenchick at Hook 42 commented
Status: Needs review » Reviewed & tested by the community

Thanks for uploading a new patch. It looks good and applies as expected.

I tried a new method of creating patches, seems like I haven't quite mastered it yet ... :)

gnuget’s picture

gnuget
Primary language Spanish
CreditAttribution: gnuget as a volunteer and at Agaric commented
Status: Reviewed & tested by the community » Fixed

It looks great!

Thank you very much!

loopduplicate’s picture

loopduplicate
she/her
Location Burning Token, California
CreditAttribution: loopduplicate at Hook 42 commented

Welcome... been using advanced help for years... about time I give back a little :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.