Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
As per the Drupal 8 release schedule , this is right time to start porting this great module.
Comment | File | Size | Author |
---|---|---|---|
#1 | advanced_help-1928218.patch | 34.91 KB | manu4543 |
Comments
Comment #1
manu4543 CreditAttribution: manu4543 commentedsubmitting patch
Comment #2
Manuel Garcia CreditAttribution: Manuel Garcia commentedhook_init has been removed, see:
https://drupal.org/node/2013014
Comment #2.0
Manuel Garcia CreditAttribution: Manuel Garcia commentedcomplemented text
Comment #3
cweagansNot only is hook_init gone, but so is overlay, so you can just remove that whole function without causing any problems :)
Comment #4
gilmordHi,
I`d like to help you with porting oh this module to Drupal 8.
Is it still actual?
Comment #5
gisle@gilmord (and others interested in creating a version of ADvanced Help for Drupal 8:
I've just signed on as maintainer for this module, and I would love to see someone working on a Drupal 8 version.
Unless you have a CV that shows some experience with Drupal, I would like to see some code before assigning co-maintainership with responsibility to oversee development for Drupal 8. The best way is probably to create a sandbox with an initial Drupal 8 version (i.e. not only a stub). I'll review the sandbox and if looks OK, I'll assign co-maintainership.
Comment #6
gisleSetting correct version.
Comment #7
gnugetI want to take a stab at this, I will create a sandbox and let you know when I have something usable.
Comment #8
gisle@gnuget,
great! Let me know when you have something reviewable.
Comment #9
gnugetHi @gisle.
You can check my progress here:
https://www.drupal.org/sandbox/gnuget/2488438
So far the module can be installed and it has a basic functionality.
There are still a ton of things to do a few of them are:
Some titles are missingI will continue working on this, and I will be commenting here my progress.
Comment #11
gisle@gnuget,
great job!
I've added the code in your sandbox to the repo and made you a co-maintainer of the project. You should now be able to push to the regular Advanced help repo.
I think that to keep to the "spirit" of Drupal 8, we should use YAML within Advanced help as well.
Comment #12
gnugetGreat, I will push my changes in the regular repo now.
Thanks.
Comment #13
Manuel Garcia CreditAttribution: Manuel Garcia as a volunteer commentedThis is great news muchas gracias @gnuget!
Comment #14
gisle@gnuget, what do you think of this one? #2492565: Why clutter the admin menu? Move Advanced Help under Help
I am travelling just now, so I won't have time to take a proper look at it until later, but I am leaning towards positive. If we move it, no separate icon for Advanced help will be needed.
Comment #15
gnugetSadly even if we move it, we will need a separate icon, because the default menu can't have submenus. :(
But the idea is good because Administration menu is very popular, and a lot of users use it.
Comment #16
gnugetNow the module is functional, it works and the only change is we need to use the YML files instead of the INI files.
I just wanted give you an update of the status of this because the next week I will be traveling so I will not have much time to work on this until I come back (I come back in June 8).
The are still some things missing:
If someone of you want to work in something specific of the things above, feel free to create an issue.
Regards.
Comment #17
mbrett5062 CreditAttribution: mbrett5062 commentedJust for information, you can do the following in the "AdvancedHelpController"
Replace all instances of l() and t() with the following:
$this->l()
&$this->t()
See this article for an explanation why this is good.
A Peek at Traits in Drupal 8
Also I have locally changed the following section of code around handling "Markdown" files.
Still not working for .md files, but I think this is an improvement. Issue may be with Markdown module or Libraries module.
Comment #18
gnugetHi @mbrett5062
Thanks for the link related with the t() and l() functions, I've changed the code accordingly in my last commit.
Also I added support for the readme.md files.
I will continue working on this.
Regards.
Comment #19
gnugetI'm going to close this issue because the branch now exists and we can report further issues directly in the issue queue.
Thanks!