Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Had to revert back to 7.x.21. After updating to 7.x.23, .js is no longer added to footer (it stays in the header) and on one site, after saving a node, all advagg .js aggregates are not added at all until cache is cleared. The .js files come back in header after, but this occurs every time a node is saved after cache clear.
Comment | File | Size | Author |
---|---|---|---|
#12 | advagg-2877882-fix-function-name.patch | 487 bytes | mikeytown2 |
Comments
Comment #2
tfranz CreditAttribution: tfranz commentedMaybe it has something to do with a "wrong function name" https://www.drupal.org/node/2877679:
Changing line 911 in advagg_mod.module seems to help:
Comment #3
Coupon Code Swap CreditAttribution: Coupon Code Swap commentedI tried applying that hack and advagg .js files are still being removed. Back to 7.x.21...
Comment #4
mikeytown2 CreditAttribution: mikeytown2 commentedI switched it so it gets called outside of the alter. http://cgit.drupalcode.org/advagg/tree/advagg.module#n3981
Comment #5
wellsAlso experiencing this on 7.x-2.23.
For the record, a work around to at least get JS to load is to go to
/admin/config/development/performance/advagg/mod
and change the Move JS to the footer option to Disabled. This, of course, keep JS in the header, but maintains compression and other features, if rollback is not an option.Comment #6
mikeytown2 CreditAttribution: mikeytown2 commentedWhat other css/js sub modules are you using? What theme is being used?
Comment #7
wellsIn my case -
Theme: Bootstrap 7.x-3.13
Sub-modules enabled:
Comment #8
mikeytown2 CreditAttribution: mikeytown2 commentedmagic module? CDN?
Comment #9
wellsNo Magic, no CDN. I believe the only other front-end module I use is jQuery Update to use jQuery 1.10.
Comment #10
wellsFurther note - I just tested this with a vanilla setup on simplytest.me. I was able to reproduce the issue with the following parts:
I went through and mirrored my own settings and found that
All but what is in the $all_in_footer_list
option is part of the trigger. All other settings the same, changing this toAll but JavaScript Libraries
resolves the issue.Let me know if you need a full description of the settings - or can I just send you the test machine URL?
Edit: Yeah, apparently it just auto-fills the password, so go nuts: https://dcozo.ply.st
Comment #12
mikeytown2 CreditAttribution: mikeytown2 commentedBack from vacation. Simple fix here.
Comment #13
wellsTested and working. Thanks!
Comment #14
Coupon Code Swap CreditAttribution: Coupon Code Swap commented@mikeytown2 Thanks! That simple patch did the trick :)
Comment #15
TynanFox CreditAttribution: TynanFox as a volunteer commented#12 worked for me! Thank you so much!