AdvAgg and s3fs fail.

I can confirm this bug as I reported in #2721469-43: AdvAgg & s3fs: rename and temp dir issues..

For the missing implementation of stream_metadata(), it is another bug from s3fs. Please see #2826372: AdvAgg - S3fsStreamWrapper::stream_metadata is not implemented.

According to my understanding, it seems the temporary file was created at temporary directory but not the location specify at $dir.

$temporary_file = @drupal_tempnam($dir, 'advagg_file_');

In my installation, `$dir` stored value `public://advagg_js/` but the temp files is created at '/tmp/' but not in S3 bucket.

When it go through `advagg_rename()`, the $source is always empty and its real path can never be found.

function advagg_rename($source, $destination) {
  $real_source = drupal_realpath($source);
  $real_source = $real_source ? $real_source : $source;
  $real_destination = drupal_realpath($destination);
  $real_destination = $real_destination ? $real_destination : $destination;

  if (!@rename($real_source, $real_destination)) {
    if (!file_unmanaged_move($source, $destination)) {
      return FALSE;
    }
  }

  return $destination;
}

I move its priority to major since s3fs is wisely used in large-scale site.

So first step is to not use touch, correct?

Second step is to get rid of all the workarounds for the limitations of drupal_tempnam and just implement my own version as it shouldn't cause as many issues.

I'll need feedback on if this change works. Thinking this will do the trick.

Should be fixed.

I think the last patch is going to the right track. I would like to remove the tedious conditions by replacing a custom file touch function too. But I didn't because I can't fully understand those long code B).

I will test it today. Thanks again.

I would like to say it works perfectly! Thanks @mikeytown2