Incompatibility with S3FS module [#2842163]

After enabling the AdvAgg module, the screen returns the following error:

The website encountered an unexpected error. Please try again later.
Error: Call to undefined method Drupal\s3fs\S3fsStreamOverrideManager::preparePath() in Drupal\advagg\State\Files->__construct() (line 68 of modules/contrib/advagg/src/State/Files.php).

Not sure if it's AdvAgg's responsibility to make sure that the function exists before calling it (and perhaps calling another function if it does not exist) or if it's S3FS's responsibility to provide a function with that name that mirrors the real function. Regardless, they appear to be incompatible at this time.

Comments

Comment #1

9 January 2017 at 17:16

belvedere created an issue. See original summary.

Comment #2

belvedere CreditAttribution: belvedere commented 9 January 2017 at 17:45

Issue tags:

+AssetDumper

Comment #3

alex_optim

🇺🇦 Rivne

CreditAttribution: alex_optim commented 2 February 2017 at 07:22

Assigned:

Unassigned

» alex_optim

Comment #4

alex_optim

🇺🇦 Rivne

CreditAttribution: alex_optim commented 2 February 2017 at 07:58

Assigned:

alex_optim

» Unassigned

Comment #5

mikeytown2 CreditAttribution: mikeytown2 commented 4 February 2017 at 00:47

~~Have you tried the latest dev? #2843510: AdvAgg and s3fs fail.~~

Ah 8.x ok

Comment #6

kducharm CreditAttribution: kducharm at CivicActions commented 5 February 2017 at 17:55

This is actually caused because both AdvAgg and S3FS are overriding the asset.css.dumper and asset.js.dumper services. The easiest solution (if you don't need to store css/js files in S3) is to remove or rename modules/s3fs/src/S3fsServiceProvider.php. That will allow AdvAgg's service overrides to work again.

The longer solution is that both AdvAgg and S3FS should probably be using aliases for the asset.css.dumper and asset.js.dumper and/or Service Decorators so that both modules could be compatible with each other. If both AdvAgg and S3fs didn't directly override the core asset dumpers and each added a service alias like advagg.asset.css.dumper, you could put an alias entry in your services.yml file in docroot/sites/default like:

asset.css.dumper:
  alias: advagg.asset.css.dumper
asset.js.dumper:
  alias: advagg.asset.js.dumper

...or S3fs could put some logic into its Service Provider so that it's configurable somehow to enable/disable the overrides

Comment #7

NickDickinsonWilde

He/Him/His

English

Victoria, BC (T'So-uke lands)

CreditAttribution: NickDickinsonWilde at BriarMoon Design commented 8 March 2017 at 03:15

Status:

Active

» Postponed

mmph that's a somewhat complicated topic/refactor area that I've been thinking about. For now I'll note that it has an incompatibility with S3FS and figure out the best way to fix it for next release (ie after the release I do tonight).

Comment #8

NickDickinsonWilde

He/Him/His

English

Victoria, BC (T'So-uke lands)

CreditAttribution: NickDickinsonWilde at BriarMoon Design commented 9 June 2017 at 17:42

Version:	8.x-2.x-dev	» 8.x-3.x-dev
Status:	Postponed	» Fixed

I'm no longer overriding asset.*.dumper services in 8.x-3.x in core. (Optional module may end up doing so, but hopefully not).
Won't fix for 8.x-2.x as that would be a major change.