When I enabled "Deferred CSS Execution: Use JS to load CSS" in head I got an error:
Exception: Invalid JS asset type. in Drupal\advagg\Asset\JsCollectionRenderer->render() (line 102 of /code/modules/contrib/advagg/src/Asset/JsCollectionRenderer.php).

After debugging module I checked out that the code in the hook alter in AdvAgg_mod uses hardcoded path to module's JS and CSS files.
I changed path with drupal_get_path() function and created a patch.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Archual created an issue. See original summary.

Archual’s picture

Issue summary: View changes

Status: Needs review » Needs work

The last submitted patch, 2: advagg-fix_path-2822527-2.patch, failed testing.

The last submitted patch, 2: advagg-fix_path-2822527-2.patch, failed testing.

The last submitted patch, 2: advagg-fix_path-2822527-2.patch, failed testing.

The last submitted patch, 2: advagg-fix_path-2822527-2.patch, failed testing.

Archual’s picture

Issue summary: View changes
NickDickinsonWilde’s picture

Status: Needs review » Needs work

The last submitted patch, 9: advagg-fix_path-2822527-3.patch, failed testing.

The last submitted patch, 9: advagg-fix_path-2822527-3.patch, failed testing.

The last submitted patch, 9: advagg-fix_path-2822527-3.patch, failed testing.

The last submitted patch, 9: advagg-fix_path-2822527-3.patch, failed testing.

NickDickinsonWilde’s picture

Status: Needs work » Needs review

Ah I see... slightly odd patch file - doesn't include the full path to the changed file.

  • NickWilde committed 7eccd39 on 8.x-2.x authored by Archual
    Issue #2822527 by Archual: Invalid JS asset type when enabling Deferred...
NickDickinsonWilde’s picture

Assigned: Archual » Unassigned
Status: Needs review » Fixed

Comitted, thanks for the patch!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

matsbla’s picture

I experience a similar issue when I try to run update.php while "Deferred CSS Execution: Use JS to load CSS" is enabled.

I've opened an issue about it here;
https://www.drupal.org/node/2837012