Problem/Motivation

Similar to and following #3132735: Update the Drupal logo the logo/icon for Drupal in the admin bar should probably be updated so we're not using the 8 version on 9 sites.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#17 icon-after.png10.71 KBsnehal-chibde
#17 icon-before.png9.98 KBsnehal-chibde
#4 icon-update-3163092-4.patch5.56 KBkevinfunk
#3 icon-update-3163092-3.patch4.45 KBjanehollander

Issue fork adminimal_admin_toolbar-3163092

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

neclimdul created an issue. See original summary.

klemendev’s picture

klemendev commented

The icon looks a bit strange since the last Admin Toolbar update when viewing admin pages and becomes a bit smaller when hovered over.

janehollander’s picture

janehollander commented
Status: Active » Needs review
StatusFileSize
new icon-update-3163092-3.patch4.45 KB

Here is a patch that display's the Drupal 9 icon for Drupal 9 sites.

kevinfunk’s picture

kevinfunk
he/him
commented
StatusFileSize
new icon-update-3163092-4.patch5.56 KB

Adding to janehollander's patch to fix the issue with the D8 logo in #2.

klemendev’s picture

klemendev commented

Sorry, forgot to note #2 was for D8 ;)

sergiur’s picture

sergiur
he/him
Primary language English
Location London, UK
commented
Status: Needs review » Reviewed & tested by the community

works well, thank you

holo96’s picture

holo96 commented

Works for me too

m4olivei’s picture

m4olivei
he/him
Primary language English
Location Grimsby, ON
commented

Adding my +1. This is working great for us.

bdanin’s picture

bdanin commented

#3 works well for me in Drupal 9.

jsutta’s picture

jsutta commented

+1 #4 works for me on D9 (figured I'd try this one out since it applies to both D8 and D9 so seems to be the most complete patch).

zorz made their first commit to this issue’s fork.

phily’s picture

phily
he/him
Primary language French
Location 🇪🇺🇫🇷 Paris, France
commented

Patch #4 works for me using Drupal 9.3.4 and adminimal_admin_toolbar 8.x-1.11
Thanks

energee’s picture

energee commented
Status: Reviewed & tested by the community » Needs work

Going to need a D10 merge request or patch to roll this in!

johnpicozzi made their first commit to this issue’s fork.

johnpicozzi opened merge request !8

johnpicozzi’s picture

johnpicozzi
Primary language English
Location Providence, RI
commented
Status: Needs work » Needs review

Added the contents of the patch in #4 as an MR. The MR needs testing and review. Moving this to needs review.

snehal-chibde’s picture

snehal-chibde commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new icon-before.png9.98 KB
new icon-after.png10.71 KB

hello @johnpicozzi, I have tested the MR on drupal 10.3.1 version.
adminimal_admin_toolbar version 2.0.x.

The changes are working as expected and now can see the updated icon of Drupal.

Added before and after screenshots for reference.
RTBC++

alxgl’s picture

alxgl commented
Status: Reviewed & tested by the community » Needs work

Actually the #4 doesn't work properly anymore on Drupal 10 with Admin Toolbar Tools enabled.

The Drupal icon comes then from tools.css and it's now blue (instead of white in the original patch) and not well sized, because it's supposed to fit with Admin Toolbar layout.

It's clearly visible in #17 screens.

avattikonda’s picture

avattikonda
Primary language English
Location Boston
commented

Patch #4 works for me using Drupal 10.3.1

alxgl’s picture

alxgl commented

Like I said, it "works" if you're just expecting not to have a Drupal 8 logo but it's not good enough.

The patch is targeting a .toolbar-icon-9 class which does not exist anymore. The logo you see is not from the Adminimal Admin Toolbar module. It's a fallback from Admin Toolbar Tools.

A new drupal-10.svg (even just a copy of the drupal-9 version) and new .toolbar-icon-10 classes are needed to work properly in Drupal 10.

liuyuanchao changed the visibility of the branch 3163092-update-icon to hidden.

liuyuanchao opened merge request !10

liuyuanchao’s picture

liuyuanchao commented

I add a new MR for the issue.
But I am wondering if it would be better to not support the Drupal8 and remove the drupal-8.svg.

alxgl’s picture

alxgl commented

Thanks liuyuanchao, your MR seems to work way better than the other recent patches.

In the era of Drupal 11, I agree with you on removing the Drupal 8 icon.

liuyuanchao’s picture

liuyuanchao commented
Status: Needs work » Needs review