Let admin_toolbar_tools depend on admin_toolbar

Andreas (@donquixote)!! Thanks a lot for creating this issue and a merge request, it's greatly appreciated! 🙏

OK, so this is related to #3556081: Admin Toolbar Tools: Remove dependency on Admin Toolbar where the dependency to admin_toolbar was removed in admin_toolbar_tools.

The idea behind this change was to try getting the module compatible with the new Core Navigation....
and as much "standalone"' as possible, since nothing really in from the code perspective would absolutely require enabling admin_toolbar....

But it looks like another module will be taking care of this, see:
#3556898-4: Admin toolbar tools: Improve support for core Navigation

I haven't had the time to look at the impact you mentioned in the issue summary:

A consequence is that a bunch of the extra links called "Delete" or other now appear in the top level of the toolbar. Not good.

Not sure exactly what to do at this point.... I would have to do a bit of testing and thinking.... whether we would roll back on this change, or just try fixing the resulting side effect...

But I just wanted to give you a quick reply with a bit of background behind this change.

I'll try taking a closer look at this issue this weekend and see what we could do to fix the problem 👍

Thanks again very much for your interest Andreas! 😊

When I want this functionality with the Navigation module, I use Navigation Extra Tools.

Installing a module called "Admin Toolbar" in order to use it's submodule to enhance a module called Navigation is extremely confusing.

Thanks a lot Andrew (@mortona2k)! 🙏

Well received, and I agree as well....
When we made this change, we were not aware the module Navigation Extra Tools existed.

The idea behind the change was to try to provide a solution to still integrate/support with the core Navigation module, seeing how things were evolving in the community, see in particular #3449462: Future of Admin Toolbar if Toolbar is removed from Drupal core, discussing about future evolutions and the features the module should cover.

Overall, since the Navigation Extra Tools module exists, it seems probably better to have these features taken care of more specifically in that module.

What should we do now Andrew and Andreas? 😅
Would you like us to roll-back on this change?

It's not really a big deal overall .... but from a conception/maintenance standpoint, isn't it better to keep each brick of the module a bit more "stand alone"/ autonomous?

Personally, I'm open either way .... I wouldn't mind rolling back on this or keeping it as it is ... 😊

Thanks again for your interest and feedback!

My issue was more of a minor annoyance. For a long time, I would spin up a new site and enable admin_toolbar_tools, and start playing with drupal. This last time, I spent a few minutes stumped on why the toolbar wasn't working as expected. I will just need to develop the muscle memory to enable admin_toolbar as well. I'm unsure how this affects newer users of Drupal who are unfamiliar with these modules, or how toolbar is different than navigation.

Thanks Andrew!

I get what you're saying: overall ... there's no real point of having admin_toolbar_tools enabled by itself ...
From a functional standpoint, it might be more user friendly to have admin_toolbar enabled at the same time as admin_toolbar_tools.

The difference is so minor overall... it's just a matter of specifying the modules when enabling with drush or checking one more checkbox when enabling through the backend....

Either way, I'm really open. 😊
From a maintenance standpoint, I prefer keeping it as it is ==> less work, changes and doc 😅
But I'm really not against rolling back on this change. 👌

I'm leaning towards not changing anything. Maybe add a line to the readme or project page.

Hopefully in the future we'll see more recipes that bundle things like this. I can imagine an admin enhancements recipe with a collection of someone's favorite tweaks.

If we had to worry about all my minor annoyances, we'd never get anything done. 😛