The 'Administration menu' entry of the 'Flush caches' menu has become more and more useless in D7. If a user notices that something has gotten wrong with admin menu, she expects one item to restore functionality, not two. Since the difference between those two items is hard to explain, and the menu system is a lot faster than it was in D6, I've combined their functionality. 'Flush menu cache' now flushes all menu-related caches, period.

CommentFileSizeAuthor
admin_menu-wtf.patch947 bytessmk-ka
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented

I don't know of any performance improvements to the menu system in D7 - the better performance may be caused by a small amount of menu links.

Anyway, I see your UX point.

+++ admin_menu.inc	9 Sep 2009 20:14:06 -0000
@@ -393,12 +392,10 @@ function _admin_menu_developer_modules()
     case 'menu':
       menu_rebuild();
+      // Flush client-side cache hashes.
+      cache_clear_all('*', 'cache_admin_menu', TRUE);
       break;

menu_rebuild() already invokes admin_menu_flush_caches(), which just does that.

I'm on crack. Are you, too?

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Title: UX: Flush admin menu cache WTF » Remove "Administration menu" from cache flushing options
Status: Needs review » Postponed

We need to postpone this, since admin_menu contains stale data too often currently. Only rebuilding admin_menu is way faster than to rebuild things that don't need to be rebuilt.

truls1502’s picture

truls1502
he/him
Primary language Norwegian Bokmål
CreditAttribution: truls1502 as a volunteer and at SignWo AS commented
Issue summary: View changes
Status: Postponed » Postponed (maintainer needs more info)
Issue tags: +postponed2w

I am sorry for no reply until now.

There are many issues regarding this module admin_menu which is a bit difficult for us to follow up since some of the issues might be already outdated, or is already fixed by the module or any other modules or itself core which means that the problem might no longer need to be fixed.

We can see that the issue has been created for a few years ago, I hope it is okay for you that I am postponing the issue, and give you around two weeks. If you still face the problem, could you tell us the step by step when until you get the error message or what is frustrated you, and a list of modules you are using related to admin_menu and a screenshot that might help us? So it makes us easier to reproduce your issue.

However, after two weeks with no feedback - we will close this issue. So in case, you noticed it after the issue is closed, do not hesitate to reopen it like and fill information which is mentioned above.

So before giving us a feedback, do you mind to test it again with our latest 7.x-3.x-dev?

Thank you for understanding! :)

truls1502’s picture

truls1502
he/him
Primary language Norwegian Bokmål
CreditAttribution: truls1502 as a volunteer and at SignWo AS commented
Status: Postponed (maintainer needs more info) » Closed (cannot reproduce)
Issue tags: -postponed2w

This issue has been automatically marked as closed because it has not had recent activity after the last post.

However, if you or someone is still facing the same issue as described to the issue, could you please to re-open the issue by changing the status of the issue, and add an explanation with more details which can help us to reproduce your situation.

Again, thank you for your contributions! :)