Underscores in custom content types breaks the edit content type menu trail

Hi Sun

I just added a native Drupal content type that had an underscore, and the menu works correctly. I also added a custom module via the hook_node_info that specifies the module as "node", rather than my custom module, and the error still happens.

<?php
/**
 * Implementation of hook_node_info().
 */
function jm_node_info() {
  return array(

    // Fine
    'client' => array(
      'name' => t('Client'),
      'module' => 'jm',
      'description' => t("A client of Caign Webs."),
      'has_title' => TRUE,
      'title_label' => t('Name'),
      'has_body' => TRUE,
      'body_label' => t('Details'),
    ),

    // Broken
    'project_notes' => array(
      'name' => t('Project notes'),
      'module' => 'jm',
      'description' => t("Project notes."),
      'has_title' => TRUE,
      'title_label' => t('Title'),
      'has_body' => TRUE,
      'body_label' => t('Notes'),
    ),

    // Broken
    'project_test' => array(
      'name' => t('Project notes'),
      'module' => 'node',
      'description' => t("Project notes."),
      'has_title' => TRUE,
      'title_label' => t('Title'),
      'has_body' => TRUE,
      'body_label' => t('Notes'),
    ),
);
}
?>

The menu parent is set to admin, all of the menu paths work correctly.

I just run a few tests, initially having difficulty mimicking the bug. However, the following can be used to mimic it:

Clean install, drupal-6-dev from August 27, 2008 6:29:59 PM (the only D6 for testing I had. The same bug was seen in D6.4)

Enable a test module, CCK, Text, Admin menu.

Ensure that the cache is flushed/up to date

Add new items to node_info hook, using underscores, flush the cache and the error appears

The test module before the changes was:

; test.info
name = "Administration Menu Test"
description = "For testing."
package = "Other"
core = 6.x

<?php
// test.module

/**
* Implementation of hook_node_info().
*/
function test_node_info() {
  return array(

    // Fine
    'client' => array(
      'name' => t('Client'),
      'module' => 'test',
      'description' => t("A client of Caign Webs."),
      'has_title' => TRUE,
      'title_label' => t('Name'),
      'has_body' => TRUE,
      'body_label' => t('Details'),
    ),

    // Broken
    'project_notes' => array(
      'name' => t('Project notes'),
      'module' => 'test',
      'description' => t("Project notes."),
      'has_title' => TRUE,
      'title_label' => t('Title'),
      'has_body' => TRUE,
      'body_label' => t('Notes'),
    ),
);
}

?>

And after everything was installed/caches flushed, etc

<?php

/**
* Implementation of hook_node_info().
*/
function test_node_info() {
  return array(

    // Fine
    'client' => array(
      'name' => t('Client'),
      'module' => 'test',
      'description' => t("A client of Caign Webs."),
      'has_title' => TRUE,
      'title_label' => t('Name'),
      'has_body' => TRUE,
      'body_label' => t('Details'),
    ),

    // Broken
    'project_notes' => array(
      'name' => t('Project notes'),
      'module' => 'test',
      'description' => t("Project notes."),
      'has_title' => TRUE,
      'title_label' => t('Title'),
      'has_body' => TRUE,
      'body_label' => t('Notes'),
    ),

    // Broken
    'project_notes_3' => array(
      'name' => t('Project notes'),
      'module' => 'test',
      'description' => t("Project notes 3."),
      'has_title' => TRUE,
      'title_label' => t('Title'),
      'has_body' => TRUE,
      'body_label' => t('Notes'),
    ),

    'project_notes_2' => array(
      'name' => t('Project notes 2'),
      'module' => 'test',
      'description' => t("Project notes 2."),
      'has_title' => TRUE,
      'title_label' => t('Title'),
      'has_body' => TRUE,
      'body_label' => t('Notes'),
    ),

    // Broken
    'project_test' => array(
      'name' => t('Project notes'),
      'module' => 'node',
      'description' => t("Project notes."),
      'has_title' => TRUE,
      'title_label' => t('Title'),
      'has_body' => TRUE,
      'body_label' => t('Notes'),
    ),
);
}
?>

The main difference was that CCK displayed errors after adding the extra content types using this procedure. I do not think that these errors appeared on the system when the bug first showed itself, but I can not be 100% sure about this.

    * notice: Undefined index: url_str in C:\bin\web\drupal\cvs-versions\drupal-6-dev\sites\all\modules\cck\content.module on line 123.
    * notice: Undefined index: url_str in C:\bin\web\drupal\cvs-versions\drupal-6-dev\sites\all\modules\cck\content.module on line 123.
    * notice: Undefined index: url_str in C:\bin\web\drupal\cvs-versions\drupal-6-dev\sites\all\modules\cck\content.module on line 123.

Also as a follow up, I've uninstalled and reinstalled everything and the first few items work correctly, all of the new extra content types are still broken.

After dropping the database and starting afresh, the error was mimicked using the full module from above using these steps (done individually, order of the last two steps is not important):

Install clean Drupal 6
Install test module
Install admin menu

The patch by itself has not fixed the issue on the first site that I tried it on.

eg: This is still happening:

[icon] > Administer > Edit
[icon] > Administer > Edit
[icon] > Administer > Manage Fields
[icon] > Administer > Manage Fields
...

I really do not know why the menu system plays with underscores and hyphens, but must be a bit of a nightmare working this stuff out.

I tested the patch on both the 6.x-1.x-dev (2008-Oct-26) and version 1.1 with the same result, but on a live site; not on the code supplied to mimic the bug given above. Did the patch work on the example content above? I've deleted that setup so it would take some time resetting this up.