Hi there,
There is one each() call in this module that can trigger PHP notices on PHP 7.2. The fix is quick, and I will attach a patch.
Please review when you have some time.

Thank you.

CommentFileSizeAuthor
#2 admin-menu-2929025-each-function-deprecated-php-7.2.patch575 bytesAyesh
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Ayesh created an issue. See original summary.

Ayesh’s picture

Ayesh CreditAttribution: Ayesh commented
Status: Active » Needs review
FileSize
admin-menu-2929025-each-function-deprecated-php-7.2.patch575 bytes
delta’s picture

delta CreditAttribution: delta as a volunteer commented
Status: Needs review » Reviewed & tested by the community

+1 work as expected, thanks for the patch

NWOM’s picture

NWOM CreditAttribution: NWOM commented

#2 worked for me as well. Thank you!

Als’s picture

Als
Location Milano, Italia
CreditAttribution: Als commented

#2 works for me too.

Using Administration Menu 7.x-3.0-rc5 with Drupal 7.59 and PHP 7.2.4.

Rob C’s picture

Rob C CreditAttribution: Rob C commented

As #2947772: Fully support PHP 7.2 in Drupal 7 is moving forward, the patch in #2 works.

Farnoosh’s picture

Farnoosh CreditAttribution: Farnoosh as a volunteer commented

Patch #2 works for me.

truls1502’s picture

truls1502
he/him
Primary language Norwegian Bokmål
CreditAttribution: truls1502 as a volunteer commented

I can also confirm that the patch #2 works perfectly. :)

akolahi’s picture

akolahi CreditAttribution: akolahi commented

#2 works

  • truls1502 committed 71148b3 on 7.x-3.x 
    Issue #2929025 by Ayesh, truls1502: [PHP 7.2] each() function is...
truls1502’s picture

truls1502
he/him
Primary language Norwegian Bokmål
CreditAttribution: truls1502 as a volunteer and at SignWo AS commented
Status: Reviewed & tested by the community » Fixed

Fixed and added in 7.x-3.x-dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

mrgoodfellow’s picture

mrgoodfellow CreditAttribution: mrgoodfellow commented

Seems to be working great for me. Any idea when the next release will be bundled to include this PHP 7.2 fix?

StephenRobinson’s picture

StephenRobinson CreditAttribution: StephenRobinson commented

will this get pushed to a release?

Patrick Ruytings’s picture

Patrick Ruytings CreditAttribution: Patrick Ruytings commented

How can I apply this patch?

truls1502’s picture

truls1502
he/him
Primary language Norwegian Bokmål
CreditAttribution: truls1502 as a volunteer and at SignWo AS commented
Related issues: +#2939236: Next 7.x Release

It is already in 7.x-3.x-dev.

But you if you want to have a stable release, you can help us to fix from the issue list for admin_menu. :)

manali_phadke’s picture

manali_phadke CreditAttribution: manali_phadke at TATA Consultancy Services for Pfizer, Inc. commented

#2 works for me. This resolves the warning "each() function is deprecated". Thanks

thtas’s picture

thtas CreditAttribution: thtas commented

Considering php 5.6 is now EOL, it would be very useful to get a release out for this.
When moving sites to php 7 it always hurts to have to bring in dev modules.