I have been using the Administration Menu module on a Domain Access site and have noticed that the module's default menu caching means that menu items are incorrect when I switch between domains (they are cached with a particular base URL).

File admin_menu.module includes a call to variable_get('admin_menu_cache_server', TRUE);, which always returns true as it appears there is no way of creating or updating this variable via the UI. It seems to me that it would make sense for this variable to be configured in the settings form alongside the option to toggle client-side caching.

I'd be happy to commit a patch for this but I'd first like to know if there is a reason why this variable has been made non-configurable. I couldn't find anything relevant in the commit history.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

S Payne created an issue. See original summary.

S Payne’s picture

Issue summary: View changes
S Payne’s picture

Issue summary: View changes
S Payne’s picture

As per my original comment this may require further discussion, but I have created a patch for this issue

S Payne’s picture

Version: 7.x-3.0-rc5 » 7.x-3.x-dev
Status: Active » Needs review
truls1502’s picture

Status: Needs review » Postponed (maintainer needs more info)
Issue tags: +postponed2w

I am sorry for no reply until now.

There are many issues regarding this module admin_menu which is a bit difficult for us to follow up since some of the issues might be already outdated, or is already fixed by the module or any other modules or itself core which means that the problem might no longer need to be fixed.

We can see that the issue has been created for a few years ago, I hope it is okay for you that I am postponing the issue, and give you around two weeks. If you still face the problem, could you tell us the step by step when until you get the error message or what is frustrated you, and a list of modules you are using related to admin_menu and a screenshot that might help us? So it makes us easier to reproduce your issue.

However, after two weeks with no feedback - we will close this issue. So in case, you noticed it after the issue is closed, do not hesitate to reopen it like and fill information which is mentioned above.

So before giving us a feedback, do you mind to test it again with our latest 7.x-3.x-dev?

Thank you for understanding! :)

truls1502’s picture

Status: Postponed (maintainer needs more info) » Closed (cannot reproduce)
Issue tags: -postponed2w

This issue has been automatically marked as closed because it has not had recent activity after the last post.

However, if you or someone is still facing the same issue as described to the issue, could you please to re-open the issue by changing the status of the issue, and add an explanation with more details which can help us to reproduce your situation.

Again, thank you for your contributions! :)