In #282775: Hide disabled menu items menu items that are hidden were removed.
"$data['link']['hidden'] == 1" is checked.
But there are also links with "-1" as value for hidden. Those should be hidden too. Toolbar module doesn't display them. There "!$item['link']['hidden']" is checked to know if the menu item should be displayed.

CommentFileSizeAuthor
#1 admin_menu-hidden-items-2494441-1.patch1.21 KBmfernea
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mfernea’s picture

mfernea CreditAttribution: mfernea at AmeXio commented
Status: Active » Needs review
FileSize
admin_menu-hidden-items-2494441-1.patch1.21 KB

Here is the patch.

Status: Needs review » Needs work

The last submitted patch, 1: admin_menu-hidden-items-2494441-1.patch, failed testing.

mfernea’s picture

mfernea CreditAttribution: mfernea at AmeXio commented

The test is failing because in AdminMenuLinkTypesTestCase->testLinkTypes there is a section "Verify that MENU_LOCAL_TASKs appear". But I don't think that MENU_LOCAL_TASKs should appear. In _menu_link_build there is this code:

// Hide all items that are not visible in the tree.
elseif (!($item['type'] & MENU_VISIBLE_IN_TREE)) {
  $item['hidden'] = -1;
}

which sets "hidden" as -1 for all MENU_LOCAL_TASKs.

So I think that this module should alter the links' type it wants in the menu and make them "visible in tree".
What do you think?

truls1502’s picture

truls1502
he/him
Primary language Norwegian Bokmål
CreditAttribution: truls1502 as a volunteer and at SignWo AS commented
Status: Needs work » Postponed (maintainer needs more info)
Issue tags: +postponed2w

I am sorry for no reply until now.

There are many issues regarding this module admin_menu which is a bit difficult for us to follow up since some of the issues might be already outdated, or is already fixed by the module or any other modules or itself core which means that the problem might no longer need to be fixed.

We can see that the issue has been created for a few years ago, I hope it is okay for you that I am postponing the issue, and give you around two weeks. If you still face the problem, could you tell us the step by step when until you get the error message or what is frustrated you, and a list of modules you are using related to admin_menu and a screenshot that might help us? So it makes us easier to reproduce your issue.

However, after two weeks with no feedback - we will close this issue. So in case, you noticed it after the issue is closed, do not hesitate to reopen it like and fill information which is mentioned above.

So before giving us a feedback, do you mind to test it again with our latest 7.x-3.x-dev?

Thank you for understanding! :)

truls1502’s picture

truls1502
he/him
Primary language Norwegian Bokmål
CreditAttribution: truls1502 as a volunteer and at SignWo AS commented
Status: Postponed (maintainer needs more info) » Closed (cannot reproduce)
Issue tags: -postponed2w

This issue has been automatically marked as closed because it has not had recent activity after the last post.

However, if you or someone is still facing the same issue as described to the issue, could you please to re-open the issue by changing the status of the issue, and add an explanation with more details which can help us to reproduce your situation.

Again, thank you for your contributions! :)