Convert hook_menu() to routing system [#2402185]

Comment	File	Size	Author
#12	admin_menu-2402185-hookmenu-12.patch	4.14 KB	HongPong
8.x-3.x: PHP 7.1 & MySQL 5.5, D8.6.7 Patch Failed to Apply
#5	admin_menu-convert-menu-to-yml-2402185-5.patch	3.39 KB	kerby70
8.x-3.x: PHP 5.5 & MySQL 5.5, D8.6.1 Build Successful PHP 7.1 & MySQL 5.5, D8.6.1 Build Successful PHP 7.2 & MySQL 5.5, D8.6.1 Build Successful
#2	interdiff-2402185-1-2.txt	986 bytes	kerby70
#2	admin_menu-convert-menu-to-yml-2402185-2.patch	3.39 KB	kerby70

#1	admin_menu-convert-menu-to-yml-2402185-1.patch	3.4 KB	kerby70

Comment #1

kerby70 CreditAttribution: kerby70 at Blink Reaction (now part of FFW) commented 24 March 2015 at 17:23

Title:	convert hook_menu() to routing system	» Convert hook_menu() to routing system
Status:	Active	» Needs review

File	Size
admin_menu-convert-menu-to-yml-2402185-1.patch	3.4 KB

Attached is a patch converting the hook_menu items to routes and menu links for two.

Three of these call functions that need to be implemented in the new form or controller classes. I had to take the liberty of naming them AdminMenuController and AdminMenuConfigForm and assuming the method names for the controller.

I am going to take a look to see if there is a task for the controller and form next.

Log in or register to post comments

Comment #2

kerby70 CreditAttribution: kerby70 at Blink Reaction (now part of FFW) commented 24 March 2015 at 17:23

File	Size
admin_menu-convert-menu-to-yml-2402185-2.patch	3.39 KB

interdiff-2402185-1-2.txt	986 bytes

Updates based on #2012194: system_settings_form() removed in drupal 8 https://www.drupal.org/node/2012194#comment-9694189 settings change.

Log in or register to post comments

Comment #3

kerby70 CreditAttribution: kerby70 at Blink Reaction (now part of FFW) commented 24 March 2015 at 17:24

1 file was hidden/shown/deleted

File	Size
admin_menu-convert-menu-to-yml-2402185-1.patch	3.4 KB

Log in or register to post comments

Comment #4

joachim CreditAttribution: joachim commented 24 March 2015 at 17:28

Should that be Form instead of From?

Log in or register to post comments

Comment #5

kerby70 CreditAttribution: kerby70 at Blink Reaction (now part of FFW) commented 24 March 2015 at 18:49

File	Size
admin_menu-convert-menu-to-yml-2402185-5.patch	3.39 KB
8.x-3.x: PHP 5.5 & MySQL 5.5, D8.6.1 Build Successful PHP 7.1 & MySQL 5.5, D8.6.1 Build Successful PHP 7.2 & MySQL 5.5, D8.6.1 Build Successful

Yes that should be form not from.

Attached fixed.

Log in or register to post comments

Comment #6

nitesh624

he/him

English

Ranchi, India

CreditAttribution: nitesh624 as a volunteer and at Indian Institute of Technology (IIT) Bombay commented 9 December 2017 at 19:22

Assigned:

Unassigned

» nitesh624

Log in or register to post comments

Comment #7

Anonymous (not verified) CreditAttribution: Anonymous at Websolutions Agency commented 22 August 2018 at 12:19

Status:

Needs review

» Reviewed & tested by the community

Patch applied and working fine.

Log in or register to post comments

Comment #8

truls1502

he/him

Norwegian Bokmål

CreditAttribution: truls1502 as a volunteer and at SignWo AS commented 2 October 2018 at 12:07

Status:

Reviewed & tested by the community

» Needs review

Let's set the status to NR so people look at this.

Log in or register to post comments

Comment #9

2 October 2018 at 13:01

Status:

Needs review

» Needs work

The last submitted patch, 5: admin_menu-convert-menu-to-yml-2402185-5.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Log in or register to post comments

Comment #10

truls1502

he/him

Norwegian Bokmål

CreditAttribution: truls1502 as a volunteer and at SignWo AS commented 2 October 2018 at 13:41

Could someone here do a reroll of #5 against 7.x-3.x-dev? :)

Log in or register to post comments

Comment #11

HongPong CreditAttribution: HongPong at kor group commented 17 January 2019 at 17:08

Status:

Needs work

» Needs review

There should be a newline at end of file admin_menu.routing.yml .

This applies cleanly to the current head. Apart from fixing the newline i think this is probably good to apply at least to get us in the right direction.

I fixed some double newlines on other files as well as the missing newline.