When viewing the main permissions page, the permissions are collapsed properly.

But, when viewing a specific role they are not collapsed.

CommentFileSizeAuthor
#6 permissions_collapse_on_role_page-2346465-6.patch621 bytesAnonymous (not verified)
#1 permissions_collapse_on_role_page-2346465-1.patch709 bytesAnonymous (not verified)
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Issue summary: View changes
Status: Active » Needs review
FileSize
permissions_collapse_on_role_page-2346465-1.patch709 bytes

Here's a quick patch for this.

jaylotta’s picture

jaylotta CreditAttribution: jaylotta commented

Thanks for the quick response.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented

No problem; glad it's working for you.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Needs review » Reviewed & tested by the community
Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Version: 7.x-3.0-rc4 » 7.x-3.x-dev
Status: Reviewed & tested by the community » Needs work

I think this could be simplified by just using if (strpos($_GET['q'], 'admin/people/permissions') === 0)

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Needs work » Needs review
FileSize
permissions_collapse_on_role_page-2346465-6.patch621 bytes

Good idea; here's the revised patch, now against 7.x-3.x.

truls1502’s picture

truls1502
he/him
Primary language Norwegian Bokmål
CreditAttribution: truls1502 as a volunteer and at SignWo AS commented
Status: Needs review » Postponed (maintainer needs more info)
Issue tags: +postponed2w

I am sorry for no reply until now.

There are many issues regarding this module admin_menu which is a bit difficult for us to follow up since some of the issues might be already outdated, or is already fixed by the module or any other modules or itself core which means that the problem might no longer need to be fixed.

We can see that the issue has been created for a few years ago, I hope it is okay for you that I am postponing the issue, and give you around two weeks. If you still face the problem, could you tell us the step by step when until you get the error message or what is frustrated you, and a list of modules you are using related to admin_menu and a screenshot that might help us? So it makes us easier to reproduce your issue.

However, after two weeks with no feedback - we will close this issue. So in case, you noticed it after the issue is closed, do not hesitate to reopen it like and fill information which is mentioned above.

So before giving us a feedback, do you mind to test it again with our latest 7.x-3.x-dev?

Thank you for understanding! :)

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet at The University of British Columbia commented
Status: Postponed (maintainer needs more info) » Reviewed & tested by the community

This does what it says on the tin, I use filter_perms so I don't use this but did try it out to see what it did.
Example this role filtered permissions page doesn't collapse by group as it does the full list:
https://site.test/admin/people/permissions/2

https://site.test/admin/people/permissions

truls1502’s picture

truls1502
he/him
Primary language Norwegian Bokmål
CreditAttribution: truls1502 as a volunteer and at SignWo AS commented
Issue tags: -postponed2w

  • truls1502 committed 489ae8a on 7.x-3.x 
    Issue #2346465 by truls1502, Dave Reid, joelpittet: Permissions do not...
truls1502’s picture

truls1502
he/him
Primary language Norwegian Bokmål
CreditAttribution: truls1502 as a volunteer and at SignWo AS commented
Status: Reviewed & tested by the community » Fixed

It has been committed and fixed now.

Thank you everyone :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.