From #1688166-16: [META] As a Drupal community member, I would like to see Edit module de-coupled from any particular toolbar implementation:

Posted by Gábor Hojtsy on August 31, 2012 at 12:01pm new

@klonos: right, as per http://drupal.org/files/re-integrate-with-shortcut.patch above, we introduced edit_toggle_links() as an API function to get the render array for the items we need to toggle the functionality. The CSS selectors in JS and CSS we have are using the markup resulting from this render array and are independent of the containing wrappers I believe. The JS changes did include specific selectors for toolbar and navbar, so depending on the wrapper for the admin_menu, we might need some more changes there for admin_menu. I don't know of any issues people opened to integrate with admin_menu, but we are open to any code suggestions :)

Care to implement this functionality? Thanx for considering.

Comments

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
CreditAttribution: klonos commented

...related D8 toolbar.module core issue: #1847198: Update the structure returned by hook_toolbar()

askandlearn’s picture

askandlearn CreditAttribution: askandlearn commented

I am just a simple site builder. Drupal without admin_menu makes me sad. I use this all day. The drop down menu prevents thousands of unnecessary clicks per week. In the Spark 7.x-1.0-alpha9 I installed today, there doesn't seem to be a way to use admin_menu in the regular view. Strangely, I can see admin_menu in the ipad view, but I would rather not build sites all day in ipad view. :-(

Is there a way I can use admin_menu in Spark?

truls1502’s picture

truls1502
he/him
Primary language Norwegian Bokmål
CreditAttribution: truls1502 as a volunteer and at SignWo AS commented
Issue summary: View changes
Status: Active » Postponed (maintainer needs more info)
Issue tags: +postponed2w

I am sorry for no reply until now.

There are many issues regarding this module admin_menu which is a bit difficult for us to follow up since some of the issues might be already outdated, or is already fixed by the module or any other modules or itself core which means that the problem might no longer need to be fixed.

We can see that the issue has been created for a few years ago, I hope it is okay for you that I am postponing the issue, and give you around two weeks. If you still face the problem, could you tell us the step by step when until you get the error message or what is frustrated you, and a list of modules you are using related to admin_menu and a screenshot that might help us? So it makes us easier to reproduce your issue.

However, after two weeks with no feedback - we will close this issue. So in case, you noticed it after the issue is closed, do not hesitate to reopen it like and fill information which is mentioned above.

So before giving us a feedback, do you mind to test it again with our latest 7.x-3.x-dev?

Thank you for understanding! :)

truls1502’s picture

truls1502
he/him
Primary language Norwegian Bokmål
CreditAttribution: truls1502 as a volunteer and at SignWo AS commented
Status: Postponed (maintainer needs more info) » Closed (cannot reproduce)
Issue tags: -postponed2w

This issue has been automatically marked as closed because it has not had recent activity after the last post.

However, if you or someone is still facing the same issue as described to the issue, could you please to re-open the issue by changing the status of the issue, and add an explanation with more details which can help us to reproduce your situation.

Again, thank you for your contributions! :)