Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I was thinking, let's improve js events on this great toolbar :
- until now, when you click on a primary link of the toolbar, it shows the secondary links : why not add a "toggle" behavior, when re-clicking on the same primary link, that'll hide the secondary
- second request : doubleclicking on the primary link shows the page of the primary link, for example 'Configure' goes to 'admin/settings'
What do you think about it ?
Comment | File | Size | Author |
---|---|---|---|
#7 | improved_toolbar_events_with_animation.patch | 3.28 KB | Jackinloadup |
#6 | improved_toolbar_events_with_animation.patch | 2.79 KB | Jackinloadup |
#5 | admin-540558-5.patch | 930 bytes | SebCorbin |
#1 | admin-540558-1.patch | 824 bytes | SebCorbin |
Comments
Comment #1
SebCorbin CreditAttribution: SebCorbin commentedI made a tiny patch for my own request :)
Feedback your impressions...
Comment #2
Jackinloadup CreditAttribution: Jackinloadup commentedOdd.. i wasnt able to patch it. It patched in the HEAD but seemed to break the whole thing. Then patched it to the current dev and it failed.
patch to HEAD:
$ patch -p0 < admin-540558-1.patch.txt
patching file toolbar/admin_toolbar.js
Hunk #1 succeeded at 30 (offset 1 line).
patch to DEV
$ patch -p0 < admin-540558-1.patch.txt
patching file toolbar/admin_toolbar.js
Hunk #1 FAILED at 29.
i will try to patch manually later
Comment #3
SebCorbin CreditAttribution: SebCorbin commentedDid you patch it from the module root directory ?
Comment #4
SebCorbin CreditAttribution: SebCorbin commentedComment #5
SebCorbin CreditAttribution: SebCorbin commentedThat was my fault : I wasn't working on the nightly build.
Here's my updated patch
Comment #6
Jackinloadup CreditAttribution: Jackinloadup commentedI really liked this patch and decided to expand on it with some animation.
Im not sure i like it my way more or not but please voice your thoughts/ideas!
apply to lastest dev
Comment #7
Jackinloadup CreditAttribution: Jackinloadup commentedI implemented a small change that makes the animation not happen onload as it became an annoyance.