I was thinking, let's improve js events on this great toolbar :

  • until now, when you click on a primary link of the toolbar, it shows the secondary links : why not add a "toggle" behavior, when re-clicking on the same primary link, that'll hide the secondary
  • second request : doubleclicking on the primary link shows the page of the primary link, for example 'Configure' goes to 'admin/settings'

What do you think about it ?

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

SebCorbin’s picture

Assigned: Unassigned » SebCorbin
Status: Active » Needs review
FileSize
824 bytes

I made a tiny patch for my own request :)

Feedback your impressions...

Jackinloadup’s picture

Odd.. i wasnt able to patch it. It patched in the HEAD but seemed to break the whole thing. Then patched it to the current dev and it failed.

patch to HEAD:
$ patch -p0 < admin-540558-1.patch.txt
patching file toolbar/admin_toolbar.js
Hunk #1 succeeded at 30 (offset 1 line).

patch to DEV
$ patch -p0 < admin-540558-1.patch.txt
patching file toolbar/admin_toolbar.js
Hunk #1 FAILED at 29.

i will try to patch manually later

SebCorbin’s picture

Did you patch it from the module root directory ?

SebCorbin’s picture

Status: Needs review » Needs work
SebCorbin’s picture

Version: 6.x-1.0-beta3 » 6.x-1.x-dev
Status: Needs work » Needs review
FileSize
930 bytes

That was my fault : I wasn't working on the nightly build.

Here's my updated patch

Jackinloadup’s picture

I really liked this patch and decided to expand on it with some animation.
Im not sure i like it my way more or not but please voice your thoughts/ideas!

apply to lastest dev

Jackinloadup’s picture

I implemented a small change that makes the animation not happen onload as it became an annoyance.