on this page /admin/config/user-interface/addthis/advanced
hit save
open the 'Service URLs' fieldset
and an additional 'http' is added
This will keep going

CommentFileSizeAuthor
#7 addthis-extra_http_added-2713271-7.patch356 bytesgisle
#5 addthis-fix_the_http_issue-2713271-5.patch794 bytespallavi_sugandhi

Comments

SocialNicheGuru created an issue. See original summary.

gisle’s picture

gisle
he/him
Primary language Norwegian Bokmål
Location Norway
commented

Confirming that this is reproducable.

madan879’s picture

madan879 commented
Assigned: Unassigned » madan879
pallavi_sugandhi’s picture

pallavi_sugandhi commented
Assigned: madan879 » pallavi_sugandhi
pallavi_sugandhi’s picture

pallavi_sugandhi commented
Assigned: pallavi_sugandhi » Unassigned
Status: Active » Needs review
StatusFileSize
new addthis-fix_the_http_issue-2713271-5.patch794 bytes

I have created the patch for 'http' issue. please review and update status.

madan879’s picture

madan879 commented
Status: Needs review » Reviewed & tested by the community

Hi @pallavi_sugandhi,

Your patch is work for me.... Its solved the issue for 'http'..

gisle’s picture

gisle
he/him
Primary language Norwegian Bokmål
Location Norway
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new addthis-extra_http_added-2713271-7.patch356 bytes

Patch in #5 works, but is 4 lines of complex code when a single line of simple code would suffice.

I've attached a simpler patch that also fixes this problem.

Kudos to pallavi_sugandhi for locating the buggy function.

pallavi_sugandhi’s picture

pallavi_sugandhi commented
Status: Needs review » Reviewed & tested by the community

devad’s picture

devad commented

It seems that commit #9 (899ad0e) has nothing to do with patch #7. Commit #9 was all about readme files.

The commit of patch 7 was done later:

3 Jun 2016 at 13:07 CEST
Commit 1e9a355 on 7.x-4.x

devad’s picture

devad commented
Related issues: +#2285177: Always use https

Since patch is committed closing this issue as fixed.

If you experience https issues still, there is a kind of follow-up here: #2285177: Always use https

devad’s picture

devad commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.