Token in metatag causing undefined index error [#2679014]

Using the metatag module and using available address field tokens for certain tags causes the below error.

Notice: Undefined index: format_handlers in addressfield_tokens() (line 223 ... of addressfield/addressfield.tokens.inc

Comment	File	Size	Author
#4	addressfield-token_in_metatag_causing_undefined_error-2679014-4-do-not-test.patch	860 bytes	sourabh.singhal

Comments

1 March 2016 at 21:26

yoftahe.addweb commented 12 November 2016 at 07:37

Can you please provide the scenario to generate the same notice?

That would be helpful.

sourabh.singhal commented 30 November 2016 at 06:31

Assigned:

Unassigned

sourabh.singhal commented 30 November 2016 at 06:41

Status:

Active

» Needs review

Status	File	Size
new	addressfield-token_in_metatag_causing_undefined_error-2679014-4-do-not-test.patch	860 bytes

Hi 3dnathaniel,

Here is the patch attached for the same. Please review.

Thanks

German

Porta Westfalica

commented 2 July 2019 at 08:35

Status:

Needs review

» Needs work

Patch in #4 leads to an undefined $format_handlers variable if the !empty() doesn't evaluate to true. This is not a proper fix.

Btw. this doesn't fix empty tokens in metatags FYI.