Addresses migration to git [#1050196]

Just wondering how this project will move over to git and how a user like me who doesn't currently have a cvs account can clone the project to help with patches?

I do have a GitHub account but I'm not certain if that the direction drupal.org headed in.

Comments

Comment #1

AlexisWilke CreditAttribution: AlexisWilke commented 3 February 2011 at 19:26

I still have to switch to git, but submitting patches with a "diff -dur" format has been the standard on Drupal.org

Also when submitting a patch it is a good idea to test the possible side effects. For instance, removing the labels from all the default output and making it optional (which would be a neat feature) would affect all parts: regular Addresses, views, CCK... so it would be required to test all the parts in that case. Not only that, it will affect the other modules such as Addresses extras.

Thank you.
Alexis Wilke

Comment #2

dkinzer CreditAttribution: dkinzer commented 3 February 2011 at 19:48

Of course.

Are you referring to the the patch I submitted recently for addresses_cck (#324331-27: CCK addresses fields not displayed in views)?

The changes I made there were to the 'views data' object so they would only affect Views.

As for the labels, I only made changes to titles in order to make it easier to find the correct fields when creating the views. But again that shouldn't affect anything but how the labels appear on admin panel for a Views.

Though, admittedly I am not sure if that's what you are referring to.

Best regards,

Comment #3

AlexisWilke CreditAttribution: AlexisWilke commented 3 February 2011 at 22:02

dkinzer,

No, the patch you submitted looks good to me. Also... in regard to the foreach() I wouldn't use the reference but $key => column as it is usually done in Drupal. And you added/removed some empty lines here and there. It should not appear in the patch. If you become a co-maintainer, you'll be free to do so in the source, but in patches it tends to be distracting. 8-)

Thank you.
Alexis