adaptivetheme/at_core/templates/panels-pane.tpl.php has a bug regarding the pane title.

As of panels 7.x-3.4, users can change the pane title's tag to something different than <h2>.

Currently, adaptivetheme/at_core/templates/panels-pane.tpl.php code reads as:

<?php print render($title_prefix); ?>
  <?php if ($title): ?>
    <h2<?php print $title_attributes; ?>><?php print $title; ?></h2>
  <?php endif; ?>
<?php print render($title_suffix); ?>

It needs to be changed to:

<?php print render($title_prefix); ?>
  <?php if ($title): ?>
    <<?php print $title_heading; ?><?php print $title_attributes; ?>>
    <?php print $title; ?>
    </<?php print $title_heading; ?>>
  <?php endif; ?>
<?php print render($title_suffix); ?>

I'm working behind a proxy so I'm not really able to create a proper patch using git, but hopefully the attached file will suffice.

CommentFileSizeAuthor
at_core-panels-pane-title.patch519 bytesaseabrook
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

aseabrook created an issue. See original summary.

aseabrook’s picture

Issue summary: View changes
Jeff Burnz’s picture

Title: adaptivetheme/at_core/templates/panels-pane.tpl.php has a major bug regarding pane titles (patch included) » Support $title_heading levels in panels-pane.tpl.php
Version: 7.x-3.4 » 7.x-3.x-dev
Category: Bug report » Feature request
Priority: Critical » Normal
Jeff Burnz’s picture

I haven't tested with this version of Panels as yet, do you know if $title_heading has a default value or we need to set it to h2 for BC?

aseabrook’s picture

Hey Jeff, I believe $title_heading is defaulted to h2 (the default in the drop-down is set to h2 in the panel page settings) and panel page settings require you to choose from only the available options in the array (h1, h2, h3, h4, h5, h6, span, div). Sorry it took a while to get back to you here, been out sick for a while.