The Nov 24th and 25th releases seem to crash the whole front end - I'm getting tags with region classes echoed to the screen, including in the block-display page. Restoring to previous version brings the site back. Clearing cache doesn't help. It could be something I did, but I wanted to get this report out there. I'm using Drupal 8.0.0.

Output now looks like this:

 < class="l-r region pr-leaderboard__leaderboard">
User menu

    My account
    Log out

< class="l-r region pr-header__header-first">
CommentFileSizeAuthor
#4 twig.zip285.73 KBTodd Young
#4 AT_and_subtheme.zip1.11 MBTodd Young
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Todd Young created an issue. See original summary.

Todd Young’s picture

Todd Young CreditAttribution: Todd Young commented

I don't know if this was happening before, but I am now getting the following 404 errors:

search.css.map
/themes/my_subtheme/styles/css/components

responsive-menus.css.map
/themes/my_subtheme/styles/css/components

taxonomy.css.map
/themes/my_subtheme/styles/css/components

(etc)
Jeff Burnz’s picture

Jeff Burnz CreditAttribution: Jeff Burnz commented

Is this online?

Strait off I am pretty stumped as to why this would happen, the output is wrong because there is no region or block markup, and as to why this escaping output to screen is very odd.

I need you to do a few things:

1) zip your version of AT Core AND your sub theme and attach them here.
2) zip sites/default/files/php/twig and attach it here.

The map 404 errors you can ignore, I will fix this shortly, basically in the past I was removing the .map files from generated themes but not deleting the references in CSS files (hence Chrome etc will record a 404 as it tries to load the .map). map files are used when debugging SASS during development.

Todd Young’s picture

Todd Young CreditAttribution: Todd Young commented
FileSize
AT_and_subtheme.zip1.11 MB
twig.zip285.73 KB

Not online yet, but here are the zips you requested. At some point, if nobody else reports the same issue, then I must be the edge case. If at any point this isn't helpful to you please feel free to close/more-info the issue. I just wanted to make sure it wasn't a system-wide bug, and thought it was strange that it happened reliably after up/downgrading the theme.

Jeff Burnz’s picture

Jeff Burnz CreditAttribution: Jeff Burnz commented

OK, I have figured this out. Basically there were template changes between the time you created your theme and now. Here are the steps to fix your theme:

  1. Delete adaptivetheme entirely, then download it again and add to the themes folder. The reason I want you to do this is you have merged to different versions and there are now duplicated templates in at_core, we need to fix that and the best way is just nuke the whole lot and replace with a fresh version.
  2. Copy the region.html.twig and html.html.twig templates from the at_core/templates and replace the ones in your theme with these new files. You'll find both of them in at_core/templates/layout
  3. Save the Layout Settings for your theme. This is quite crucial as the path to page templates changed in this latest version and to update it you must save the layout at least once.

After all this clear the cache and you should be good to go.

One final thing you could do is add this to your themes info.yml file, anywhere in there will do, this will give nice styles in CK Editor:

ckeditor_stylesheets:
  - styles/css/components/base.css
Todd Young’s picture

Todd Young CreditAttribution: Todd Young commented
Status: Active » Fixed

Working! Thanks for the fix. I have new issues with my CSS losing the battle against the color module now, but that's something I can tackle another day.

As always, thanks for the great work!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.