Duplicate id if more than one message type at the same time [#1950008]

The following function from at_core/inc/theme.inc creates more than one div with id="messages" if there are messages of more than one type to be displayed, leading to invalid HTML:

function adaptivetheme_status_messages($vars) {
  $display = $vars['display'];
  $output = '';

  $status_heading = array(
    'status' => t('Status message'),
    'error' => t('Error message'),
    'warning' => t('Warning message'),
  );
  foreach (drupal_get_messages($display) as $type => $messages) {
    $output .= "<div id=\"messages\"><div class=\"messages $type\">";
    if (!empty($status_heading[$type])) {
      $output .= '<h2 class="element-invisible">' . $status_heading[$type] . "</h2>";
    }
    if (count($messages) > 1) {
      $output .= " <ul>";
      foreach ($messages as $message) {
        $output .= '  <li>' . $message . "</li>";
      }
      $output .= " </ul>";
    }
    else {
      $output .= $messages[0];
    }
    $output .= "</div></div>";
  }
  return $output;
}

Comments

Comment #1

Jeff Burnz CreditAttribution: Jeff Burnz commented 22 March 2013 at 11:46

Assigned:

Unassigned

» Jeff Burnz

Yeah, it needs to be fixed, thanks for posting the issue, I have been meaning to fix this for ages.

Comment #2

Jeff Burnz CreditAttribution: Jeff Burnz commented 22 March 2013 at 11:52

Status:

Active

» Fixed

This is what it should be like, with just one ID wrapper, not one for each message, since they already have wrappers - will commit shortly:

function adaptivetheme_status_messages($vars) {
  $display = $vars['display'];
  $output = '';

  $status_heading = array(
    'status' => t('Status message'),
    'error' => t('Error message'),
    'warning' => t('Warning message'),
  );

  $output .= "<div id=\"messages\">";

  foreach (drupal_get_messages($display) as $type => $messages) {
    $output .= "<div class=\"messages $type\">";
    if (!empty($status_heading[$type])) {
      $output .= '<h2 class="element-invisible">' . $status_heading[$type] . "</h2>";
    }
    if (count($messages) > 1) {
      $output .= " <ul>";
      foreach ($messages as $message) {
        $output .= '  <li>' . $message . "</li>";
      }
      $output .= " </ul>";
    }
    else {
      $output .= $messages[0];
    }
    $output .= "</div>";
  }

  $output .= "</div>";

  return $output;
}